From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E70C43381 for ; Thu, 28 Feb 2019 05:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69212206B8 for ; Thu, 28 Feb 2019 05:44:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730885AbfB1Fo6 (ORCPT ); Thu, 28 Feb 2019 00:44:58 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:55986 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbfB1Fo6 (ORCPT ); Thu, 28 Feb 2019 00:44:58 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 7D71E14016672; Wed, 27 Feb 2019 21:44:57 -0800 (PST) Date: Wed, 27 Feb 2019 21:44:56 -0800 (PST) Message-Id: <20190227.214456.944810072109486180.davem@davemloft.net> To: dsahern@kernel.org Cc: netdev@vger.kernel.org, dsahern@gmail.com, ecree@solarflare.com Subject: Re: [PATCH net] ipv4: Pass original device to ip_rcv_finish_core From: David Miller In-Reply-To: <20190225215548.17340-1-dsahern@kernel.org> References: <20190225215548.17340-1-dsahern@kernel.org> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Feb 2019 21:44:57 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: David Ahern Date: Mon, 25 Feb 2019 13:55:48 -0800 > From: David Ahern > > ip_route_input_rcu expects the original ingress device (e.g., for > proper multicast handling). The skb->dev can be changed by l3mdev_ip_rcv, > so dev needs to be saved prior to calling it. This was the behavior prior > to the listify changes. > > Fixes: 5fa12739a53d0 ("net: ipv4: listify ip_rcv_finish") > Cc: Edward Cree > Signed-off-by: David Ahern Applied and queued up for -stable, thanks Dave.