From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E25F5C43381 for ; Wed, 27 Feb 2019 11:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ABA8F21734 for ; Wed, 27 Feb 2019 11:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551267491; bh=jpx8iiFK1Ne0kFk1uLaGTgra/ksImFZpE1HOrs489vQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gbr/AcoQk0C/T4hqZgESqlozpmn5DMz15qN55BLKihsG5Bl36xAgChWjepEsYCS/+ 3s61MeqtXTHByiWqNsrJe5CTSWXAJ+YuNOX37+IWJByDfakPstgJ52ZP93LTmTlcX4 49ol1rAe2aU7LKUvV1I8cmOaZFvVAYc0mdoEDjII= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727094AbfB0LiK (ORCPT ); Wed, 27 Feb 2019 06:38:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:50742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725927AbfB0LiK (ORCPT ); Wed, 27 Feb 2019 06:38:10 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C0A120C01; Wed, 27 Feb 2019 11:38:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1551267488; bh=jpx8iiFK1Ne0kFk1uLaGTgra/ksImFZpE1HOrs489vQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nsYlJmFTEpKOdeD72+5NMx+h0PV1XY68nRghnKPpm1bqrLtb2wcCPfYI0peNE1bDk g61atHYGekQAnSl9EWw9psMf0kGz8esKfZJ0lVnSoem5db7XgSZLWrWs7ELDFLqHRR Ml6Bxcf8HYCgcqxvKTauFpjsem3wcrJbA2mRSeqo= Date: Wed, 27 Feb 2019 13:38:07 +0200 From: Leon Romanovsky To: oulijun Cc: David Ahern , Steve Wise , netdev , RDMA mailing list , Stephen Hemminger Subject: Re: [PATCH iproute2-next] rdma: Add the prefix for driver attributes Message-ID: <20190227113807.GC15253@mtr-leonro.mtl.com> References: <20190227064151.25445-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IiVenqGWf+H9Y6IX" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --IiVenqGWf+H9Y6IX Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 27, 2019 at 07:30:34PM +0800, oulijun wrote: > =E5=9C=A8 2019/2/27 14:41, Leon Romanovsky =E5=86=99=E9=81=93: > > From: Leon Romanovsky > > > > There is a need to distinguish between driver vs. general exposed > > attributes. The most common use case is to expose some internal > > garbage under extremely common and sexy name, e.g. pi, ci e.t.c > > > > In order to achieve that, we will add "drv_" prefix to all strings > > which were received through RDMA_NLDEV_ATTR_DRIVER_* attributes. > > > > Signed-off-by: Leon Romanovsky a > > --- > > rdma/utils.c | 34 ++++++++++++++++++++++------------ > > 1 file changed, 22 insertions(+), 12 deletions(-) > > > > diff --git a/rdma/utils.c b/rdma/utils.c > > index 6bc14cd5..1f6bf330 100644 > > --- a/rdma/utils.c > > +++ b/rdma/utils.c > > @@ -829,27 +829,37 @@ static int print_driver_entry(struct rd *rd, stru= ct nlattr *key_attr, > > struct nlattr *val_attr, > > enum rdma_nldev_print_type print_type) > > { > > - const char *key_str =3D mnl_attr_get_str(key_attr); > > int attr_type =3D nla_type(val_attr); > > + int ret =3D -EINVAL; > > + char *key_str; > > + > > + if (asprintf(&key_str, "drv_%s", mnl_attr_get_str(key_attr)) =3D=3D -= 1) > > + return -ENOMEM; > > > > switch (attr_type) { > > case RDMA_NLDEV_ATTR_DRIVER_STRING: > > - return print_driver_string(rd, key_str, > > - mnl_attr_get_str(val_attr)); > > + ret =3D print_driver_string(rd, key_str, > > + mnl_attr_get_str(val_attr)); > > + break; > > case RDMA_NLDEV_ATTR_DRIVER_S32: > > - return print_driver_s32(rd, key_str, > > - mnl_attr_get_u32(val_attr), print_type); > > + ret =3D print_driver_s32(rd, key_str, mnl_attr_get_u32(val_attr), > > + print_type); > > + break; > > case RDMA_NLDEV_ATTR_DRIVER_U32: > > - return print_driver_u32(rd, key_str, > > - mnl_attr_get_u32(val_attr), print_type); > > + ret =3D print_driver_u32(rd, key_str, mnl_attr_get_u32(val_attr), > > + print_type); > > + break; > > case RDMA_NLDEV_ATTR_DRIVER_S64: > > - return print_driver_s64(rd, key_str, > > - mnl_attr_get_u64(val_attr), print_type); > > + ret =3D print_driver_s64(rd, key_str, mnl_attr_get_u64(val_attr), > > + print_type); > > + break; > > case RDMA_NLDEV_ATTR_DRIVER_U64: > > - return print_driver_u64(rd, key_str, > > - mnl_attr_get_u64(val_attr), print_type); > > + ret =3D print_driver_u64(rd, key_str, mnl_attr_get_u64(val_attr), > > + print_type); > > + break; > > } > > - return -EINVAL; > > + free(key_str); > > + return ret; > > } > > > > void print_driver_table(struct rd *rd, struct nlattr *tb) > > -- > > 2.19.1 > > > > > > . > > > This is fine to me and the implementation is more simple. > > Tested-by: Lijun Ou Thanks a lot. > > thanks. > --IiVenqGWf+H9Y6IX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcdnafAAoJEORje4g2clinI6cQAMlj5B6UA9lKwZ83jjt/AelN D+xTO0lmXiIV3HWbz0dguKL/7fj/GpTh+YfD+rYqJ3VmhU56BL3tUXqthXmQREkB wv/lhjJeLpqb/a75VDdmeE99S0YQkK1tDJFYvfNRsAaK3sVW/i5kjNHbwcTfDkGu pYoPWWmclwSGZnNsHjwa2LzZ1d32TgtYYoXbxS1Maqq1RW9uxKejSp0icHqVM3Cn vOUFlBWoGSvQcMbOMuClM+9g6O8DOhiCyIaCZPS2nIJFN/Z2iOBMHI2M0goN8plB b7Z8i5q9cwk0hvN9RTxNIVN1MQkpdeIXmTb81BmP+AuHRWsLZ+No3MepDUrq0zeM YFITD7AeAbIwgl61kfUBeEuSK3Tdbu39bXzz+JYs9nfaougWyWhbdnEzJCtzKCHj uS6Z4ICFvrckNybBs4GA7jrlW5hbJ5K5/rVu3i6qk3C8rLM1XWR2AyEPbX5vrwIa cfWU2dTfwK67AzcQ/GJGKkG8oEAZEreXEaezPDQozq3N62eSt0p35O6BOfdbrq3g PBWJVoTrus1XYDo/uqt1y48u9NM1yLqu1+rJ/1nCqD434yc8bVkpke/0KL01FP7C NiNB0glc/wZCkbxX60rwaN+L+tc/Zx/wtOzKvZ3jAnjJhS0KTaySRQz3z/TkxkLt NTuP5aTxGEg5ivCzn71i =pbwK -----END PGP SIGNATURE----- --IiVenqGWf+H9Y6IX--