From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/cfd=RC=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3C219C43381
	for <netdev@archiver.kernel.org>; Wed, 27 Feb 2019 12:41:19 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 00EC12133D
	for <netdev@archiver.kernel.org>; Wed, 27 Feb 2019 12:41:18 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IJ6zGAS4"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730039AbfB0MlS (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 27 Feb 2019 07:41:18 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:40212 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726419AbfB0MlR (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 27 Feb 2019 07:41:17 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=h0QoIKzfevp76NGoIn5Hrr/5XnBubsLBjiK/YACabwk=; b=IJ6zGAS4EFbl27mODLyuBUzKNj
        kyptYmQUhVu74AUD894rK1AwQWSrJZknfp5nRXkFQzgrybvbE2ibJZ6X2O9TlmyNtqg9kH/Jbu2Qp
        NKWBI9keOlLiaCWuetyH8ObRdpglrHthbwIQ5DlNg6PnRYk7mX96AQQJaA9vf2iglCpk=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gyyWO-0008RC-Ge; Wed, 27 Feb 2019 13:41:12 +0100
Date:   Wed, 27 Feb 2019 13:41:12 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Tristram.Ha@microchip.com
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: document additional
 Microchip KSZ9477 family switches
Message-ID: <20190227124112.GG3809@lunn.ch>
References: <1551224265-9304-1-git-send-email-Tristram.Ha@microchip.com>
 <1551224265-9304-2-git-send-email-Tristram.Ha@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1551224265-9304-2-git-send-email-Tristram.Ha@microchip.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Tue, Feb 26, 2019 at 03:37:43PM -0800, Tristram.Ha@microchip.com wrote:
> +				port@3 {
> +					reg = <3>;
> +					label = "lan4";
> +				};
> +				port@4 {
> +					reg = <6>;

Hi Tristram

The number after the @ must be the same as the register. So this needs
to be port@6.

   Andrew

> +					label = "cpu";
> +					ethernet = <&eth0>;
> +					fixed-link {
> +						speed = <1000>;
> +						full-duplex;
> +					};
> +				};
> +			};
> +		};
>  	};
> -- 
> 1.9.1
>