From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D66C43381 for ; Wed, 27 Feb 2019 13:13:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C1DE2133D for ; Wed, 27 Feb 2019 13:13:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="sj8d+d/p" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730284AbfB0NNq (ORCPT ); Wed, 27 Feb 2019 08:13:46 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:35416 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730120AbfB0NNp (ORCPT ); Wed, 27 Feb 2019 08:13:45 -0500 Received: by mail-wr1-f67.google.com with SMTP id t18so17914939wrx.2 for ; Wed, 27 Feb 2019 05:13:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eEk6vfcDp6Wi/LmIIAdU6KKaOVYwFsSiJK8VgbhyOIg=; b=sj8d+d/pBzEyvQQncdtvlP1gWn0ZmXcqbcE8mEQiASaJ0R6Gyyu8ZK/f+F9s7kftvq qlfYzXZggIKeENrGWvDYSN+lHvhT0t1YJbcs1Sv3+O6ZoKyaaH0bG9IW+M5dlrjojJuS sW9t8QAKZn6spokpCAli3sY5if7UZ3H7Sdi6EnlME9e8mldTnDO41/TuGV+W8nAihxr2 19tAv4gvKZx4vbUCk3nXN669SxrxEvr7Ev3cMl1+0z5LVgUOKMDWewh43IYloBhMfTQK SJhUjs6VbvhggFoUeISn+1xb6KKgfOQ+FLDcTr5jK2+hSi4WOGg1JY45Dc3ty2vUpDbr wEyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eEk6vfcDp6Wi/LmIIAdU6KKaOVYwFsSiJK8VgbhyOIg=; b=JeLkzT5I8J3eL3zKLgEN2HNsv7nji7KTC10/mX5OIvyMoBuy1y2pRI4u7xDauNo8Lz ACB/SVLQbm6yLow9hPyRUy3+1D140hM1Xc2cBeU3FSdPWqkXXSWnk3qexY/qLxICNma0 sE0xgKrpVFcPEErP85i2yr5MC3UGXpYY7VuCZyqw0lYnZ3YqV4mAcn8eYS/+WIOoMPVi BqWnCALyNCg/fh3V1e6jMKhrJ2teB6uG81/GZnokJClhPelyeqKwCNK1KEKt615zhH3Y EqNX7xAgIKFpB8vODH0buZIUVhlBBk3ffQfl9CKWGEXcAC6HcHjIV1783m4ZvwRYEKny aVLA== X-Gm-Message-State: APjAAAXkur2ugiFTgFeeEqvCrl/MAG+sn9jt0drV0EJWWLtMHBWczuyO JqrMJVcaiQZH4vKa5+1xIkfX8w== X-Google-Smtp-Source: APXvYqwUQ/bxGmqIqxIXs3EWAn4p4If06ZLJ5JGCKkSKGMm5mm3dhTTwh9cxDxHWUeoLlxjfKwY9NQ== X-Received: by 2002:a5d:5402:: with SMTP id g2mr975699wrv.280.1551273223980; Wed, 27 Feb 2019 05:13:43 -0800 (PST) Received: from localhost (mail.chocen-mesto.cz. [85.163.43.2]) by smtp.gmail.com with ESMTPSA id m189sm1537490wmf.7.2019.02.27.05.13.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 05:13:43 -0800 (PST) Date: Wed, 27 Feb 2019 14:13:42 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 8/8] devlink: fix kdoc Message-ID: <20190227131342.GD2240@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-9-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226182436.23811-9-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 26, 2019 at 07:24:36PM CET, jakub.kicinski@netronome.com wrote: >devlink suffers from a few kdoc warnings: > >net/core/devlink.c:5292: warning: Function parameter or member 'dev' not described in 'devlink_register' >net/core/devlink.c:5351: warning: Function parameter or member 'port_index' not described in 'devlink_port_register' >net/core/devlink.c:5753: warning: Function parameter or member 'parent_resource_id' not described in 'devlink_resource_register' >net/core/devlink.c:5753: warning: Function parameter or member 'size_params' not described in 'devlink_resource_register' >net/core/devlink.c:5753: warning: Excess function parameter 'top_hierarchy' description in 'devlink_resource_register' >net/core/devlink.c:5753: warning: Excess function parameter 'reload_required' description in 'devlink_resource_register' >net/core/devlink.c:5753: warning: Excess function parameter 'parent_reosurce_id' description in 'devlink_resource_register' >net/core/devlink.c:6451: warning: Function parameter or member 'region' not described in 'devlink_region_snapshot_create' >net/core/devlink.c:6451: warning: Excess function parameter 'devlink_region' description in 'devlink_region_snapshot_create' > >Signed-off-by: Jakub Kicinski Acked-by: Jiri Pirko