From: Andrew Lunn <andrew@lunn.ch>
To: Tristram.Ha@microchip.com
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch support
Date: Wed, 27 Feb 2019 14:14:38 +0100 [thread overview]
Message-ID: <20190227131438.GH3809@lunn.ch> (raw)
In-Reply-To: <1551224265-9304-3-git-send-email-Tristram.Ha@microchip.com>
> static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg)
> @@ -353,7 +363,7 @@ static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg)
> val = 0x796d;
> break;
> case MII_PHYSID1:
> - val = 0x0022;
> + val = KSZ9477_ID_HI;
> break;
> case MII_PHYSID2:
> val = 0x1631;
Hi Tristram
This seems like an unrelated change, so should be in a separate
patch. And if you change PHYID1, it would also make sense to change
PHYID2 to a #define.
Please split the tagging changes into a patch of there own.
Andrew
next prev parent reply other threads:[~2019-02-27 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 23:37 [PATCH net-next 0/3] net: dsa: microchip: add KSZ9893 switch support Tristram.Ha
2019-02-26 23:37 ` [PATCH net-next 1/3] dt-bindings: net: dsa: document additional Microchip KSZ9477 family switches Tristram.Ha
2019-02-27 12:41 ` Andrew Lunn
2019-02-26 23:37 ` [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch support Tristram.Ha
2019-02-27 13:14 ` Andrew Lunn [this message]
2019-02-26 23:37 ` [PATCH net-next 3/3] net: dsa: microchip: add other KSZ9477 switch variants Tristram.Ha
2019-02-27 6:47 ` kbuild test robot
2019-02-27 13:23 ` Andrew Lunn
2019-02-27 13:33 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227131438.GH3809@lunn.ch \
--to=andrew@lunn.ch \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).