From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8627AC43381 for ; Wed, 27 Feb 2019 13:14:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 46DCA2133D for ; Wed, 27 Feb 2019 13:14:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="2dQfDnSC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730106AbfB0NOn (ORCPT ); Wed, 27 Feb 2019 08:14:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40244 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729364AbfB0NOn (ORCPT ); Wed, 27 Feb 2019 08:14:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=puH+D18Y2EwB/sRdkFYEENG+1p2nTTd715+tgO0vtAA=; b=2dQfDnSCk0xwsuDvFFfiJqBOeX BA7GOg5e1efd1axytFudlCLIE1tl6Bneg9PWfszDR2lFDEMhbhd9uPr84xxZqdmMbWay4FF1Oe9m5 +/ktYIS3pZ8nrM1kppM2lmKi8CpXw3UvZDw2wA9AcXm81A/ukI6gEDTpij0C97A/Co7g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1gyz2k-0000D4-WF; Wed, 27 Feb 2019 14:14:38 +0100 Date: Wed, 27 Feb 2019 14:14:38 +0100 From: Andrew Lunn To: Tristram.Ha@microchip.com Cc: Florian Fainelli , Pavel Machek , UNGLinuxDriver@microchip.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/3] net: dsa: microchip: add KSZ9893 switch support Message-ID: <20190227131438.GH3809@lunn.ch> References: <1551224265-9304-1-git-send-email-Tristram.Ha@microchip.com> <1551224265-9304-3-git-send-email-Tristram.Ha@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1551224265-9304-3-git-send-email-Tristram.Ha@microchip.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg) > @@ -353,7 +363,7 @@ static int ksz9477_phy_read16(struct dsa_switch *ds, int addr, int reg) > val = 0x796d; > break; > case MII_PHYSID1: > - val = 0x0022; > + val = KSZ9477_ID_HI; > break; > case MII_PHYSID2: > val = 0x1631; Hi Tristram This seems like an unrelated change, so should be in a separate patch. And if you change PHYID1, it would also make sense to change PHYID2 to a #define. Please split the tagging changes into a patch of there own. Andrew