From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/cfd=RC=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 86E7CC43381
	for <netdev@archiver.kernel.org>; Wed, 27 Feb 2019 13:23:58 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 5681E20661
	for <netdev@archiver.kernel.org>; Wed, 27 Feb 2019 13:23:58 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="5jakY7Bh"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730114AbfB0NX5 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 27 Feb 2019 08:23:57 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:40260 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726062AbfB0NX5 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Wed, 27 Feb 2019 08:23:57 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=YrhpIOJla/U6E8a8h0LIfJbQWE5nDpMEbw8dFmVqYA0=; b=5jakY7Bhcax0j849KP17Jinx5N
        8Ao7lgu92bkn2B4BFcO7sflIJk/riyaTtJFeOM8cxuIUqHcFy1s/ZmkzKGugbR6+w3+9Q+OL5I8y6
        VYNzDLFkiEXh58LYcypkjhhvCTwar5Q50yE+IN0yX/8my9YDkLGHrZHiK+pTkNdqDlb0=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1gyzBg-0000JT-FL; Wed, 27 Feb 2019 14:23:52 +0100
Date:   Wed, 27 Feb 2019 14:23:52 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Tristram.Ha@microchip.com
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] net: dsa: microchip: add other KSZ9477
 switch variants
Message-ID: <20190227132352.GI3809@lunn.ch>
References: <1551224265-9304-1-git-send-email-Tristram.Ha@microchip.com>
 <1551224265-9304-4-git-send-email-Tristram.Ha@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1551224265-9304-4-git-send-email-Tristram.Ha@microchip.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

> +	if (dev->dev->of_node) {
> +		char name[80];
> +
> +		/* KSZ8565 chip can only be set through device tree. */
> +		if (!of_modalias_node(dev->dev->of_node, name, sizeof(name))) {
> +			if (!strcmp(name, "ksz8565")) {
> +				chip = KSZ8565_SW_CHIP;
> +				id_hi = FAMILY_ID_98;
> +				id_lo = 0x95;
> +			}
> +		}

of_device_is_compatible() seems like a better call use use.

	  Andrew