From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D884C00319 for ; Thu, 28 Feb 2019 01:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D190218A2 for ; Thu, 28 Feb 2019 01:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="vBE9ECvC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730689AbfB1Bwn (ORCPT ); Wed, 27 Feb 2019 20:52:43 -0500 Received: from mx3.wp.pl ([212.77.101.10]:36949 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730254AbfB1Bwn (ORCPT ); Wed, 27 Feb 2019 20:52:43 -0500 Received: (wp-smtpd smtp.wp.pl 29043 invoked from network); 28 Feb 2019 02:52:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1551318760; bh=c71t0zbwTKYsGqB1Qdt4FASwJl+4NYqOLoV56F9d240=; h=From:To:Cc:Subject; b=vBE9ECvCyxt4J65OMZuJrx8iydAqMatKogvuOrLRQemihJBavYKtgsDqIXA66fVKe hBjkrQOtG0ithZdN4OK7DBCsS+HnGbGCgWLoBH8idibp+8iilBvSgJllOkCgq/i2NU btNTK1N0GIW6u7v/LJlJoVeGS/edGLRt4yAWe7M8= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 28 Feb 2019 02:52:39 +0100 Date: Wed, 27 Feb 2019 17:52:18 -0800 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: si-wei liu , "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , Stephen Hemminger , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jason Wang , liran.alon@oracle.com Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Message-ID: <20190227175218.736e13b6@cakuba.netronome.com> In-Reply-To: <20190227201857-mutt-send-email-mst@kernel.org> References: <20190222100753-mutt-send-email-mst@kernel.org> <20190225210529-mutt-send-email-mst@kernel.org> <20190227173710-mutt-send-email-mst@kernel.org> <20190227184601-mutt-send-email-mst@kernel.org> <20190227193923-mutt-send-email-mst@kernel.org> <20190227165205.307ed83c@cakuba.netronome.com> <20190227201857-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 357e14ae2d8adf3d9f8268b2d9ad54c0 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 0000000 [8cP0] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 27 Feb 2019 20:26:02 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 04:52:05PM -0800, Jakub Kicinski wrote: > > On Wed, 27 Feb 2019 19:41:32 -0500, Michael S. Tsirkin wrote: > > > > As this scheme adds much complexity to the kernel naming convention > > > > (currently it's just ethX names) that no userspace can understand. > > > > > > Anything that pokes at slaves needs to be specially designed anyway. > > > Naming seems like a minor issue. > > > > Can the users who care about the naming put net_failover into > > "user space will do the bond enslavement" mode, and do the bond > > creation/management themselves from user space (in systemd/ > > Network Manager) based on the failover flag? > > Putting issues of compatibility aside (userspace tends to be confused if > you give it two devices with same MAC), how would you have it work in > practice? Timer based hacks like netvsc where if userspace didn't > respond within X seconds we assume it won't and do everything ourselves? Well, what I'm saying is basically if user space knows how to deal with the auto-bonding, we can put aside net_failover for the most part. It can either be blacklisted or it can have some knob which will effectively disable the auto-enslavement. Auto-bonding capable user space can do the renames, spawn the bond, etc. all by itself. I'm basically going back to my initial proposal here :) There is a RedHat bugzilla for the NetworkManager team to do this, but we merged net_failover before those folks got around to implementing it. IOW if NM/systemd is capable of doing the auto-bonding itself it can disable the kernel mechanism and take care of it all. If kernel is booted with an old user space which doesn't have capable NM/systemd - net_failover will kick in and do its best.