From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 649DDC43381 for ; Wed, 27 Feb 2019 20:12:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 34AF5213A2 for ; Wed, 27 Feb 2019 20:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729994AbfB0UMi (ORCPT ); Wed, 27 Feb 2019 15:12:38 -0500 Received: from mail.us.es ([193.147.175.20]:42070 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbfB0UMi (ORCPT ); Wed, 27 Feb 2019 15:12:38 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 97BE018CE8B for ; Wed, 27 Feb 2019 21:03:02 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 81A1CFB474 for ; Wed, 27 Feb 2019 21:03:02 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6F6BDFB469; Wed, 27 Feb 2019 21:03:02 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 69940FB43B; Wed, 27 Feb 2019 21:03:00 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 27 Feb 2019 21:03:00 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 460784265A2F; Wed, 27 Feb 2019 21:03:00 +0100 (CET) Date: Wed, 27 Feb 2019 21:02:59 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Roi Dayan Cc: "xiangxia.m.yue@gmail.com" , Saeed Mahameed , "gerlitz.or@gmail.com" , "netdev@vger.kernel.org" Subject: Re: [PATCH net v1] net/mlx5e: Correctly use the namespace type when allocating pedit action Message-ID: <20190227200259.ptwc7tkjejpenfnt@salvia> References: <1551184112-40686-1-git-send-email-xiangxia.m.yue@gmail.com> <42e71e1f-0a51-c517-5a93-b8d9b8c0fecf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <42e71e1f-0a51-c517-5a93-b8d9b8c0fecf@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 27, 2019 at 02:05:02PM +0000, Roi Dayan wrote: > > > On 26/02/2019 14:28, xiangxia.m.yue@gmail.com wrote: > > From: Tonghao Zhang > > > > The capacity of FDB offloading and NIC offloading table are > > different, and when allocating the pedit actions, we should > > use the correct namespace type. > > > > Fixes: c500c86b0c75d ("net/mlx5e: support for two independent packet edit actions") > > Cc: Pablo Neira Ayuso > > Signed-off-by: Tonghao Zhang > > --- > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > index 3a02b22..467ef9e 100644 > > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > > @@ -2635,7 +2635,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, > > > > if (hdrs[TCA_PEDIT_KEY_EX_CMD_SET].pedits || > > hdrs[TCA_PEDIT_KEY_EX_CMD_ADD].pedits) { > > - err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_KERNEL, > > + err = alloc_tc_pedit_action(priv, MLX5_FLOW_NAMESPACE_FDB, > > parse_attr, hdrs, extack); > > if (err) > > return err; > > > > Reviewed-by: Roi Dayan Acked-by: Pablo Neira Ayuso