From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E2BC43381 for ; Wed, 27 Feb 2019 20:27:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2FC8213A2 for ; Wed, 27 Feb 2019 20:27:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="sGQIp+zd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730485AbfB0U1W (ORCPT ); Wed, 27 Feb 2019 15:27:22 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:51206 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730337AbfB0U1V (ORCPT ); Wed, 27 Feb 2019 15:27:21 -0500 Received: by mail-wm1-f65.google.com with SMTP id n19so7120705wmi.1 for ; Wed, 27 Feb 2019 12:27:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lsXI6o9jUtMQWl5n09lMD+9v80+UhedKYWiAMZi/RB4=; b=sGQIp+zd3uQaHrEdR54rp4T9mtHxvdB3D+RVFtKn+oMU6W7hhfPMkGKcM3fE+PpJBk fMMgowv+WFS4zYgk+LZ5YbZflLy1u6ZW9VLDGb7s9WpG9nBDbMFrHGf26PaAYnN9Z4f2 k/EY35JepuRs8cO8yJfgexk3VYkoRR9QVDh5xiz8Il1ddiNBjvbGtyX50LsqNJL7pCeY Ss+0R/fKti2DHNZvXAIB1gBevPYEXhteGko8te0EL4VCQVLDuLgrULIh9KfNS+g6s2iB XdCwD/nRbEdQ13QXn+8qKtjjuTzXybZLovryRCBKAx+eh7Py8ryHvNphduLfdhgVhbOh MPFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lsXI6o9jUtMQWl5n09lMD+9v80+UhedKYWiAMZi/RB4=; b=J+tSD0cwfBcDn2Bh0LPii5pw0GtL+JeGPpYZuPbLSCs+YyYgHy5VxKn0vTfgQZE+3k If7a9MqfnlcPVzk/5T8XBtG7FiishCKi/QtJGNjACniCBVMu6bAPj5iSzDh1u30sP74v ZbbaYAoIFvEAE4ZBXVqPz0Dwx3nz31ps53BjZHWRw5ll9tt6Va+7ziXO3z+dDo9lYKsm Ue8LTQmnpIBvzLe7DZF2cNnM5V4y5MCmk11zznWkNBrLj95wOmG46wJrpZFGizNkwj0S YULlP8bEsiZNASHX7iagj05q0UbAJQCP4a7J+aVfl4qmUaJYjx+TlEaCAqoDOEJag5iR EiGw== X-Gm-Message-State: AHQUAublYNHU/syyOSLFzZRuZ3boM0MpjVo48MrIle0pF6kQnLLEOZBg UmE271TGrqBk/xJw1NiY7MIorXPIB00= X-Google-Smtp-Source: APXvYqz9Q3VnwGGoIxzYp08HU3ru3ADiHJje8erOiVlQ7uDJqVVcCh4oSK+jLS+wuX3yiD5zDuHZog== X-Received: by 2002:a1c:2947:: with SMTP id p68mr658289wmp.104.1551299240104; Wed, 27 Feb 2019 12:27:20 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id 62sm14138322wra.46.2019.02.27.12.27.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Feb 2019 12:27:19 -0800 (PST) Date: Wed, 27 Feb 2019 21:17:27 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 2/8] devlink: add PF and VF port flavours Message-ID: <20190227201727.GA2042@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-3-jakub.kicinski@netronome.com> <20190227122327.GA10571@nanopsycho> <20190227124135.GB10571@nanopsycho> <20190227092326.5abf417b@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190227092326.5abf417b@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Feb 27, 2019 at 06:23:26PM CET, jakub.kicinski@netronome.com wrote: >On Wed, 27 Feb 2019 13:41:35 +0100, Jiri Pirko wrote: >> Wed, Feb 27, 2019 at 01:23:27PM CET, jiri@resnulli.us wrote: >> >Tue, Feb 26, 2019 at 07:24:30PM CET, jakub.kicinski@netronome.com wrote: >> >>Current port flavours cover simple switches and DSA. Add PF >> >>and VF flavours to cover "switchdev" SR-IOV NICs. >> >> >> >>Example devlink user space output: >> >> >> >>$ devlink port >> >>pci/0000:82:00.0/0: type eth netdev p4p1 flavour physical >> >>pci/0000:82:00.0/10000: type eth netdev eth0 flavour pcie_pf pf 0 >> >>pci/0000:82:00.0/10001: type eth netdev eth1 flavour pcie_vf pf 0 vf 0 >> >>pci/0000:82:00.0/10002: type eth netdev eth2 flavour pcie_vf pf 0 vf 1 >> > >> >Wait a second, howcome pf and vfs have the same PCI address? >> >> Oh, I think you have these as eswitch port representors. Confusing... > >FWIW I don't like the word representor, its a port. We don't call >physical ports "representors" even though from ASIC's point of view >they are exactly the same. My point is, they are not PFs and VFs. We have to find a way to clearly see what's what.