Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: arjun@chelsio.com
Cc: netdev@vger.kernel.org, nirranjan@chelsio.com,
	indranil@chelsio.com, dt@chelsio.com, vishal@chelsio.com
Subject: Re: [PATCH net-next] cxgb4vf: Enter debugging mode if FW is inaccessible
Date: Thu, 28 Feb 2019 10:27:49 -0800 (PST)	[thread overview]
Message-ID: <20190228.102749.523293065123206627.davem@davemloft.net> (raw)
In-Reply-To: <20190228100316.9411-1-arjun@chelsio.com>

From: Arjun Vynipadath <arjun@chelsio.com>
Date: Thu, 28 Feb 2019 15:33:16 +0530

> If we are not able to reach firmware, enter debugging mode that will
> help us to get adapter logs.
> 
> Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
> Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>

Applied, however I will say:

> @@ -411,6 +411,7 @@ enum { /* adapter flags */
>  	USING_MSIX         = (1UL << 2),
>  	QUEUES_BOUND       = (1UL << 3),
>  	ROOT_NO_RELAXED_ORDERING = (1UL << 4),
> +	FW_OK              = (1UL << 5),
>  };

These macros are asking for conflicts in the global namespace and
could really use "CXGB4_XXX" prefixes.

      reply	other threads:[~2019-02-28 18:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 10:03 [PATCH net-next] cxgb4vf: Enter debugging mode if FW is inaccessible Arjun Vynipadath
2019-02-28 18:27 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190228.102749.523293065123206627.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=arjun@chelsio.com \
    --cc=dt@chelsio.com \
    --cc=indranil@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=nirranjan@chelsio.com \
    --cc=vishal@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox