From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A14F0C43381 for ; Thu, 28 Feb 2019 18:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 827C2218AE for ; Thu, 28 Feb 2019 18:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388791AbfB1SgD (ORCPT ); Thu, 28 Feb 2019 13:36:03 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36592 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387913AbfB1SgB (ORCPT ); Thu, 28 Feb 2019 13:36:01 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6D1D814BA5DDD; Thu, 28 Feb 2019 10:36:00 -0800 (PST) Date: Thu, 28 Feb 2019 10:35:59 -0800 (PST) Message-Id: <20190228.103559.1064927758602258691.davem@davemloft.net> To: lesliemonis@gmail.com Cc: netdev@vger.kernel.org, tahiliani@nitk.edu.in, dave.taht@gmail.com Subject: Re: [PATCH net-next] net: sched: pie: avoid slow division in drop probability decay From: David Miller In-Reply-To: <20190228123654.26330-1-lesliemonis@gmail.com> References: <20190228123654.26330-1-lesliemonis@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Feb 2019 10:36:00 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Leslie Monis Date: Thu, 28 Feb 2019 18:06:54 +0530 > As per RFC 8033, it is sufficient for the drop probability > decay factor to have a value of (1 - 1/64) instead of 98%. > This avoids the need to do slow division. > > Suggested-by: David Laight > Signed-off-by: Leslie Monis Applied.