From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17ADAC43381 for ; Thu, 28 Feb 2019 20:53:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E14B72084F for ; Thu, 28 Feb 2019 20:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732789AbfB1Uxl (ORCPT ); Thu, 28 Feb 2019 15:53:41 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:38646 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbfB1Uxl (ORCPT ); Thu, 28 Feb 2019 15:53:41 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::bf5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 2691514BFC37E; Thu, 28 Feb 2019 12:53:41 -0800 (PST) Date: Thu, 28 Feb 2019 12:53:40 -0800 (PST) Message-Id: <20190228.125340.1708836619677603076.davem@davemloft.net> To: andrew@lunn.ch Cc: netdev@vger.kernel.org, vivien.didelot@gmail.com, Chris.Healy@zii.aero Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix u64 statistics From: David Miller In-Reply-To: <20190228171403.17780-1-andrew@lunn.ch> References: <20190228171403.17780-1-andrew@lunn.ch> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 28 Feb 2019 12:53:41 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Lunn Date: Thu, 28 Feb 2019 18:14:03 +0100 > The switch maintains u64 counters for the number of octets sent and > received. These are kept as two u32's which need to be combined. Fix > the combing, which wrongly worked on u16's. > > Fixes: 80c4627b2719 ("dsa: mv88x6xxx: Refactor getting a single statistic") > Reported-by: Chris Healy > Signed-off-by: Andrew Lunn Applied and queued up for -stable, thanks Andrew.