From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28009C43381 for ; Thu, 28 Feb 2019 01:07:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC56720842 for ; Thu, 28 Feb 2019 01:07:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V/qR6AoH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730527AbfB1BHx (ORCPT ); Wed, 27 Feb 2019 20:07:53 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44147 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730308AbfB1BHx (ORCPT ); Wed, 27 Feb 2019 20:07:53 -0500 Received: by mail-pg1-f196.google.com with SMTP id j3so8799189pgm.11 for ; Wed, 27 Feb 2019 17:07:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0IaTzQp7X/tVo4h7LGBH/IbWXSKDcjgDYqRnC0MGdm0=; b=V/qR6AoHctf18Mw06vhUI2pK2KOG9Zxgw/M+6D+cFYbtnxpLR8MMGE257Ny9zxNwIN hwaqE9/D8EvP9p9Gz9gXmSPTYm8IA72/xJnPew2KDg1BtVwHrGNoqSD/8bNfBSZaNeub 2gVLQ3EHPACsq65zxDGaUMPBv1S8hwZoAeUDH9MYhM9C2+ZUEAUimyYHDVnuCqEOJn9/ NqHMKANvbEmqpoXyrZCTdZLlytcO2CbHj2c1attHIdYEy9JM/yas9XxyHysfI8EvhFJO XeySOvmxCfu3rUd90dulSX/jnYNPpLIdSmECD+iUu6qFfq8HVOgUEeU1Z5KiZjXx2u0x GEBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0IaTzQp7X/tVo4h7LGBH/IbWXSKDcjgDYqRnC0MGdm0=; b=uSu8FuOmJlAI45R3iqesIHXgB2je/M1cy5qAXYzCnb7SeNeKhSJ7tU9Gti2VBGmCE+ 1HXFbTh6box5N48n5bxsvfTVBGpC/1BgSzS9bfdUgr8rAbUQ4NntofFLUakZukBc324G m5piWoGrO9rODmVPmzY8/ry2JdgzmQ8Pk28Po6AG+2YnTMt4Crc2ObYmHF5PohPyK5/s WtdlOv5EhYVi1FwpwltMbiqMJBwtTVeQjOM3uAZzC+ZMDPM390mk8lhrrxJNK2fGOXrs krgl57cjzdiqd47tA/noWqtKCpyviB+LqrWQHMFVA/a0jljyPnx3ngAnrIAJi8+yNRCx EzvQ== X-Gm-Message-State: AHQUAubhYuaWvJTZofpRFdcKv0h6tdgMYx6ZlztcKAFfr1xuDqHsjNII 7Uy8VsMuvIp1oz6Tyv6l+aKGqo0h X-Google-Smtp-Source: AHgI3IYACiYae78LnGMwWDJYFR1/hJv0jRmbbDykAcHuMdHrAaTS+SYYtu0zsg/mCJV+8FtphLZyZw== X-Received: by 2002:a63:112:: with SMTP id 18mr5571598pgb.139.1551316072101; Wed, 27 Feb 2019 17:07:52 -0800 (PST) Received: from ast-mbp ([2620:10d:c090:200::3:9b13]) by smtp.gmail.com with ESMTPSA id 4sm41450909pft.96.2019.02.27.17.07.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Feb 2019 17:07:51 -0800 (PST) Date: Wed, 27 Feb 2019 17:07:49 -0800 From: Alexei Starovoitov To: Yonghong Song Cc: netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , kernel-team@fb.com Subject: Re: [PATCH bpf-next 0/2] bpf: set inner_map_meta->spin_lock_off correctly Message-ID: <20190228010748.guapaqwwha4v7apd@ast-mbp> References: <20190227212256.3856416-1-yhs@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190227212256.3856416-1-yhs@fb.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 27, 2019 at 01:22:56PM -0800, Yonghong Song wrote: > The inner_map_meta->spin_lock_off is not set correctly during > map creation for BPF_MAP_TYPE_ARRAY_OF_MAPS and BPF_MAP_TYPE_HASH_OF_MAPS. > This may lead verifier error due to misinformation. > This patch set fixed the issue with Patch #1 for the kernel change > and Patch #2 for enhanced selftest test_maps. Applied, Thanks