From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCE83C43381 for ; Thu, 28 Feb 2019 16:03:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A58B218C3 for ; Thu, 28 Feb 2019 16:03:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="w+oyJoLC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731988AbfB1QDE (ORCPT ); Thu, 28 Feb 2019 11:03:04 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35138 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729880AbfB1QDE (ORCPT ); Thu, 28 Feb 2019 11:03:04 -0500 Received: by mail-qk1-f194.google.com with SMTP id z13so12380799qki.2 for ; Thu, 28 Feb 2019 08:03:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=CfRsi928D59ZntKgsn1d40dCCTiUN4/WFuA4ItzccCU=; b=w+oyJoLCerAN635bnot1gJkALJB0dwkyFJUaufJADAzTJcFHpAiRQdZyoO/DCXtLPM xfuKjVEERcSdptNPbJFvP88XSyNL98NHl2HjAQpESZUx2mYBSPzhOBrimJDtnAaXWuYX DUl/zIbc+38MhKMZJLww0IPGbKs/2OCOU5s+BFE4Cw8UZybndSCZn8o2Bz+6mOKEApPi pIliSGbhMrRGZzMLX3KwF5vVWurI3HUHetG/xF6dqslqVBQj0s8yL+Q7NlSXY5WoMZjj OWXLgV6hR9P8hp6NX/OK0tww1F80/3anlWr+TDDRaQVfsvzJEOCqSQOiy4YDrliwuZQE j86g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=CfRsi928D59ZntKgsn1d40dCCTiUN4/WFuA4ItzccCU=; b=l0ukW1nglyYwc03LAnsthPlhy0Qds3qrvtHsgpkpFeek+VGS2FnNFwgIvJ4t/NeEsG fNrmIyiqdoURFGdJJ8nLOkpvDuGmcbbMVdChKuONJgMVP82qc/iOcDG/SomfZCmeSIRf o4cGhiGP0MsooC+7CzpHEhk0mVztz9e/FkGT1Toce2xKqcBkJEPwFhjrPJ0tF3ImYJZn 16Z0KN4y1iWpau/XdQWAPK6CutpB0R+jq/dlzIt4/ym6wUXpDMaVl1JmAjeYQgSu8Eup ZOmP/bGCcwgr42zHe9flokX6Wj5gOUIAugFG7DB0IBzjvkbkGr6uml0k1Kw/OStcAkNi 6TZQ== X-Gm-Message-State: APjAAAWdHJh+kHNtI4uYaJlWbsC0qvy7jc8phTjBIejqXS+ROZQzot4o l67WAvhL7L+Ahrar0e1/Ukd7pw== X-Google-Smtp-Source: APXvYqxkAj7052BQ2CSTl6eWj0G6H+h5BAytyeUObbSWwi+DTJd5u/JWFuVevNwKgEjM77CfY+PDNg== X-Received: by 2002:a37:47cb:: with SMTP id u194mr140650qka.296.1551369783206; Thu, 28 Feb 2019 08:03:03 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id f126sm15454688qka.14.2019.02.28.08.03.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 08:03:03 -0800 (PST) Date: Thu, 28 Feb 2019 08:02:56 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in Message-ID: <20190228080256.773f4f19@cakuba.netronome.com> In-Reply-To: <20190228150125.GB2462@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-2-jakub.kicinski@netronome.com> <20190228150125.GB2462@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Feb 2019 16:01:25 +0100, Jiri Pirko wrote: > Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@netronome.com wrote: > >diff --git a/net/Kconfig b/net/Kconfig > >index 62da6148e9f8..1efe1f9ee492 100644 > >--- a/net/Kconfig > >+++ b/net/Kconfig > >@@ -429,21 +429,12 @@ config NET_SOCK_MSG > > with the help of BPF programs. > > > > config NET_DEVLINK > >- tristate "Network physical/parent device Netlink interface" > >+ bool "Network physical/parent device Netlink interface" > > Wouldn't "default y" be better? No opinion. It used to be 'n', it didn't change here.. But we can change if we write convincing enough commit message :) Did you see cases where people "forget" to enable it? > > help > > Network physical/parent device Netlink interface provides > > infrastructure to support access to physical chip-wide config and > > monitoring. > >