From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A391BC43381 for ; Thu, 28 Feb 2019 18:14:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 264B9218C3 for ; Thu, 28 Feb 2019 18:14:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=wp.pl header.i=@wp.pl header.b="xegg9mvc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388574AbfB1SOM (ORCPT ); Thu, 28 Feb 2019 13:14:12 -0500 Received: from mx3.wp.pl ([212.77.101.9]:9044 "EHLO mx3.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfB1SOM (ORCPT ); Thu, 28 Feb 2019 13:14:12 -0500 Received: (wp-smtpd smtp.wp.pl 3168 invoked from network); 28 Feb 2019 19:14:09 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1551377649; bh=eFBogD8rRk6mHFNuodyRci62ONGEyXzt1u1itld5bTo=; h=From:To:Cc:Subject; b=xegg9mvcrnCYbQ7eFcgLbyWrpOSTWGvTxdUimS4FZt807PmerORhpzfDJK4maQXHO j5ncvB5bHBYIOfFlaCgzA8mqqpUTzJGx6EpxZGkfIhlKUROTHc6gphvoo60lele03d 0hKE9wSKUNd4O1LS/53o63p2U5do3lDzJwN0o2aU= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 28 Feb 2019 19:14:09 +0100 Date: Thu, 28 Feb 2019 10:13:56 -0800 From: Jakub Kicinski To: "Michael S. Tsirkin" Cc: si-wei liu , "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , Stephen Hemminger , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jason Wang , liran.alon@oracle.com Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Message-ID: <20190228101356.39ac70aa@cakuba.netronome.com> In-Reply-To: <20190227233812-mutt-send-email-mst@kernel.org> References: <20190225210529-mutt-send-email-mst@kernel.org> <20190227173710-mutt-send-email-mst@kernel.org> <20190227184601-mutt-send-email-mst@kernel.org> <20190227193923-mutt-send-email-mst@kernel.org> <20190227165205.307ed83c@cakuba.netronome.com> <20190227201857-mutt-send-email-mst@kernel.org> <20190227175218.736e13b6@cakuba.netronome.com> <20190227233812-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: 081bd70edb7604893998007ade3f8dd6 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [EWME] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 27 Feb 2019 23:47:33 -0500, Michael S. Tsirkin wrote: > On Wed, Feb 27, 2019 at 05:52:18PM -0800, Jakub Kicinski wrote: > > > > Can the users who care about the naming put net_failover into > > > > "user space will do the bond enslavement" mode, and do the bond > > > > creation/management themselves from user space (in systemd/ > > > > Network Manager) based on the failover flag? > > > > > > Putting issues of compatibility aside (userspace tends to be confused if > > > you give it two devices with same MAC), how would you have it work in > > > practice? Timer based hacks like netvsc where if userspace didn't > > > respond within X seconds we assume it won't and do everything ourselves? > > > > Well, what I'm saying is basically if user space knows how to deal with > > the auto-bonding, we can put aside net_failover for the most part. It > > can either be blacklisted or it can have some knob which will > > effectively disable the auto-enslavement. > > OK I guess we could add a module parameter to skip this. > Is this what you mean? Yup. > > Auto-bonding capable user space can do the renames, spawn the bond, > > etc. all by itself. I'm basically going back to my initial proposal > > here :) There is a RedHat bugzilla for the NetworkManager team to do > > this, but we merged net_failover before those folks got around to > > implementing it. > > In particular because there's no policy involved whatsoever > here so it's just mechanism being pushed up to userspace. > > > IOW if NM/systemd is capable of doing the auto-bonding itself it can > > disable the kernel mechanism and take care of it all. If kernel is > > booted with an old user space which doesn't have capable NM/systemd - > > net_failover will kick in and do its best. > > Sure - it's just 2 lines of code, see below. > > Signed-off-by: Michael S. Tsirkin > > But I don't intend to bother until there's actual interest from > userspace developers to bother. In particular it is not just NM/systemd > even on Fedora - e.g. you will need to teach dracut to somehow detect > and handle this - right now it gets confused if there are two devices > with same MAC addresses. It is a bit of a the chicken or the egg situation ;) But users can just blacklist, too. Anyway, I think this is far better than module parameters for twiddling kernel-based interface naming policy.. :S > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 955b3e76eb8d..dd2b2c370003 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -43,6 +43,7 @@ static bool csum = true, gso = true, napi_tx; > module_param(csum, bool, 0444); > module_param(gso, bool, 0444); > module_param(napi_tx, bool, 0644); > +module_param(disable_failover, bool, 0644); > > /* FIXME: MTU in config. */ > #define GOOD_PACKET_LEN (ETH_HLEN + VLAN_HLEN + ETH_DATA_LEN) > @@ -3163,6 +3164,7 @@ static int virtnet_probe(struct virtio_device *vdev) > virtnet_init_settings(dev); > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > + if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY) && > + !disable_failover) { > vi->failover = net_failover_create(vi->dev); > if (IS_ERR(vi->failover)) { > err = PTR_ERR(vi->failover); >