From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2627DC43381 for ; Thu, 28 Feb 2019 13:42:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C73812171F for ; Thu, 28 Feb 2019 13:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="ief1bk+l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732019AbfB1NmF (ORCPT ); Thu, 28 Feb 2019 08:42:05 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33713 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725967AbfB1NmF (ORCPT ); Thu, 28 Feb 2019 08:42:05 -0500 Received: by mail-wm1-f65.google.com with SMTP id c13so6657241wmb.0 for ; Thu, 28 Feb 2019 05:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aKQDxhquyltd3UPCZ0FOz6kGkidYQD6nU3wGJgi/djg=; b=ief1bk+l0Y82VYP2zTI1p8X7669DgOGwdDKPoOglh5rr4MwOCouvywTM3ssg62awVA +CcTDLCc6y2KrXLbduNnN3/d+1oAsQHgNWSWC7Mk43U/kaUft4pmcxXlQVr+E03AGD/r nHCY1YUVVN780KozKabWJirv15o6pGU58sEu5xwNWJYTPQhGiABohAFDuV3csfwmm98k bIvr1JPARCVTFFEY2g6s7Sca6ijocK25ceEiUXwlzUrpun6CZtfxKez2sLz6d/1s+/Gv 4yFEBq1Pw6DVaq01lFPf/9CdAws6QIiuG3NbJSNstz4KbE7DYNsaCVP2pItB1r+CNNtp r5Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aKQDxhquyltd3UPCZ0FOz6kGkidYQD6nU3wGJgi/djg=; b=k2imSMedVjPw5373stcIbusg613Xq3WqIh3HmOH5+CMZxb1sVE2FA4G4OuZ7lonaLd zQCMVDVtACmjsYscwa7xiLj28wCZPS363ncT91vksVwZc+5s/te4VOPWuXQuUyYt0Vq5 lTayoRLOL8zEyYsKuic22P2BH3NL6kTsS3HOtzpxdHY4+Y+HESnYtOYbCMwb9DEeisNq dt88t5JAC6FhyDv8r4vdJKnqnGdH9Ryz0SPeS+EvVTcWldivCoQcqveyeOo/8D5yOCg5 TuzIJM83hrXE7DliA58ehOxQbJzlofIlL2HymzvK11LgGnY5ditdP2P3OTvt1q+Twb95 lI2g== X-Gm-Message-State: AHQUAubwG6bNyde7/F3lw+A9TiNkEwyI/IM/b/auiHX4gMrD2cGsfr+A ekBlazC3Wc6PfDpYvsNAh7Ip6rIOv2vGbixv X-Google-Smtp-Source: APXvYqytVD2UoDqvPYzq2qQaGRrOsQmBIbJ8fC2U5HZkxheQiG62llCEnkvHB8hhnOAitIQWe6WFrA== X-Received: by 2002:a1c:e0d7:: with SMTP id x206mr3052832wmg.152.1551361323649; Thu, 28 Feb 2019 05:42:03 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id v6sm3334403wml.42.2019.02.28.05.42.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 05:42:03 -0800 (PST) Date: Thu, 28 Feb 2019 14:32:09 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, parav@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports Message-ID: <20190228133209.GA2462@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-5-jakub.kicinski@netronome.com> <20190227123753.GB2240@nanopsycho> <20190227103000.6ea6f7c0@cakuba.netronome.com> <20190228085624.GD2324@nanopsycho.orion> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190228085624.GD2324@nanopsycho.orion> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Feb 28, 2019 at 09:56:24AM CET, jiri@resnulli.us wrote: [...] >>devlink instance). Those less pipelined NICs can forward between >>ports, but still want a function per port (otherwise user space >>sometimes gets confused). If we have multiple functions which are on >>the same "switchid" they should have a single devlink instance if you >>ask me. That instance will have all the ports of the device. > >Okay, that makes sense. But the question it, can the same devlink >instance contain ports that does not have "Switchid"? > >I think it would be beneficial to have the switchid shown for devlink >ports too. Then it is clean that the devlink ports with the same >switchid belong to the same switch, and other ports under the same >devlink instance (like PF itself) is separate, but still under the same >ASIC. Working on this. Will sent patchset later today/tmrw. [...]