From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: davem@davemloft.net, linux@armlinux.org.uk, f.fainelli@gmail.com,
hkallweit1@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
maxime.chevallier@bootlin.com, gregory.clement@bootlin.com,
miquel.raynal@bootlin.com, nadavh@marvell.com,
stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com
Subject: Re: [PATCH net-next 3/3] net: phy: marvell10g: set the PHY in low power by default
Date: Thu, 28 Feb 2019 15:22:43 +0100 [thread overview]
Message-ID: <20190228142243.GA8189@lunn.ch> (raw)
In-Reply-To: <20190228134837.32740-4-antoine.tenart@bootlin.com>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
> ---
> drivers/net/phy/marvell10g.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/marvell10g.c b/drivers/net/phy/marvell10g.c
> index e5d098bd33a6..765edd34a7dd 100644
> --- a/drivers/net/phy/marvell10g.c
> +++ b/drivers/net/phy/marvell10g.c
> @@ -245,17 +245,8 @@ static int mv3310_probe(struct phy_device *phydev)
> if (ret)
> return ret;
>
> - return 0;
> -}
> -
> -static int mv3310_suspend(struct phy_device *phydev)
> -{
> - return 0;
> -}
> -
> -static int mv3310_resume(struct phy_device *phydev)
> -{
> - return mv3310_hwmon_config(phydev, true);
Hi Antoine
I'm confused.
Didn't patch 1 just add suspend and resume callback? And here you are
removing some other suspend and resume callbacks? Did we have two sets
for a short while?
Andrew
next prev parent reply other threads:[~2019-02-28 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 13:48 [PATCH net-next 0/3] net: phy: marvell10g: implement suspend/resume callbacks Antoine Tenart
2019-02-28 13:48 ` [PATCH net-next 1/3] " Antoine Tenart
2019-02-28 13:48 ` [PATCH net-next 2/3] net: phy: marvell10g: add the suspend/resume callbacks for the 88x2210 Antoine Tenart
2019-02-28 13:48 ` [PATCH net-next 3/3] net: phy: marvell10g: set the PHY in low power by default Antoine Tenart
2019-02-28 14:22 ` Andrew Lunn [this message]
2019-02-28 14:44 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228142243.GA8189@lunn.ch \
--to=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).