From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D84EC43381 for ; Thu, 28 Feb 2019 15:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D33E20C01 for ; Thu, 28 Feb 2019 15:27:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="RE+tPIJb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388459AbfB1P1L (ORCPT ); Thu, 28 Feb 2019 10:27:11 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43505 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387953AbfB1PLU (ORCPT ); Thu, 28 Feb 2019 10:11:20 -0500 Received: by mail-wr1-f68.google.com with SMTP id d17so22314257wre.10 for ; Thu, 28 Feb 2019 07:11:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZC4QFZrTnE0ECaG7p+eZ6GlZ9BfJaLnoCJwltB6kXxI=; b=RE+tPIJb02XJHWDT7tiJIlUm2txbZl0WgQ2lE1i54FnYj1ULTaRjHcP//VrGHIy1h0 spyFGqcIUEzHTNUMWb0D2wwZvq8DpIWDzzjXYfIPCCn6KDmnBBiJvhwMyPI3ClT8sLpQ swX+ST7JQJhu+vmmKqL7k3QjxjoLkGkqKI/GtVYL4AIgncZV1aAocIXmcy3HXJcJ4GJU rkhLTKbqURxUGiXPTw+DZGz6nttjEDT3HUE3JG1qo+dWTylK5FK+e9eQQP0qPLVnx5nF PEhjQaz18p0gXsFyTK0kzUmK5w8Esr/M5cskhCl3sPvb0ewy5YesL//Lh1Fcbx7YvoIc BTEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZC4QFZrTnE0ECaG7p+eZ6GlZ9BfJaLnoCJwltB6kXxI=; b=TvMoG2DHgE1fOeyevpRfCXD8z4geQet2um8kbp/GkeMb3k38gO3f2Uyn2LYO2qNpi4 kmY4qehnLTKQo4Oij2wHn3ZRSyiP/JQT1gMbwzA3tAXGlkxPLJdiqznYi8mBDapezWKq JsVw6qOpzXVtNbriru+qQRtRkyuPFEyEXoFIed+k4AuBmfJlcO+XHKU9DBJfpdNncH20 EGiL7bhFxShpJH8BO31cH1NtWC5//v5McjbTtQTW7R/kbBvuEZxrwv2aNSvbrq6MV+lC 5c0xoEguvBIZCIkY46NSCkZb1imgDmMqE3cvIgJVFOFqv5vzMOzJUVST972GPPW/UC4E UBAg== X-Gm-Message-State: APjAAAU2980YjM1ptrx9Q3j2iHGgXVUWdlmzyd8D+la5DtFLw4nFWIna fr8S/3TXTseQm85sqVNzPV0IqA== X-Google-Smtp-Source: APXvYqxt+yFao7i+txwysTHIF8ME8Phkj8SSLBIubixocAlF60m3hKd5relZ3FB9hvTb8EMjNXcr0w== X-Received: by 2002:adf:e385:: with SMTP id e5mr6927632wrm.267.1551366678883; Thu, 28 Feb 2019 07:11:18 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id i10sm52822342wrx.54.2019.02.28.07.11.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 07:11:18 -0800 (PST) Date: Thu, 28 Feb 2019 16:01:25 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in Message-ID: <20190228150125.GB2462@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-2-jakub.kicinski@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190226033407.32625-2-jakub.kicinski@netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@netronome.com wrote: [...] >diff --git a/net/Kconfig b/net/Kconfig >index 62da6148e9f8..1efe1f9ee492 100644 >--- a/net/Kconfig >+++ b/net/Kconfig >@@ -429,21 +429,12 @@ config NET_SOCK_MSG > with the help of BPF programs. > > config NET_DEVLINK >- tristate "Network physical/parent device Netlink interface" >+ bool "Network physical/parent device Netlink interface" Wouldn't "default y" be better? > help > Network physical/parent device Netlink interface provides > infrastructure to support access to physical chip-wide config and > monitoring. > [...]