From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andriin@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] tools/libbpf: signedness bug in btf_dedup_ref_type()
Date: Thu, 28 Feb 2019 21:01:31 +0300 [thread overview]
Message-ID: <20190228180131.GE9806@kadam> (raw)
In-Reply-To: <20190228175300.GB9508@kernel.org>
On Thu, Feb 28, 2019 at 02:53:00PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 28, 2019 at 08:50:35PM +0300, Dan Carpenter escreveu:
> > The "ref_type_id" variable needs to be signed for the error handling
> > to work.
>
> Does the infiniband signedness change comes as a bonus? :-)
>
Oh wow... :P
Let me resend v3.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-28 18:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 5:46 [PATCH] tools/libbpf: signedness bug in btf_dedup_ref_type() Dan Carpenter
2019-02-28 6:58 ` Yonghong Song
2019-02-28 13:36 ` Dan Carpenter
2019-02-28 17:44 ` Andrii Nakryiko
2019-02-28 17:50 ` [PATCH v2] " Dan Carpenter
2019-02-28 17:53 ` Arnaldo Carvalho de Melo
2019-02-28 18:01 ` Dan Carpenter [this message]
2019-02-28 18:06 ` [PATCH v3] " Dan Carpenter
2019-02-28 19:29 ` Song Liu
2019-03-01 0:01 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228180131.GE9806@kadam \
--to=dan.carpenter@oracle.com \
--cc=andriin@fb.com \
--cc=arnaldo.melo@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).