From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0976EC43381 for ; Fri, 1 Mar 2019 03:07:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C98E0218AE for ; Fri, 1 Mar 2019 03:07:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="vP+EOXNv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731103AbfCADHi (ORCPT ); Thu, 28 Feb 2019 22:07:38 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:44022 "EHLO mail-qt1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728082AbfCADHi (ORCPT ); Thu, 28 Feb 2019 22:07:38 -0500 Received: by mail-qt1-f179.google.com with SMTP id y4so26170472qtc.10 for ; Thu, 28 Feb 2019 19:07:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=lJrIxmcZFZWmXNWrkV4FXt9Nks+3QcwwcMu4ZtUB2fI=; b=vP+EOXNvUmnxt1fFx8QE6V6Qxqv2jsNtjGrhkzLQoL5MJGHWFluQTu4N6PEcGhPghD +dLOerewLzoSBdD0XcnUsxZMBew4Nl/fv0Kj9/Ir+c3u2mehXzTguczzW6W/9SrqHzr+ DEeeYOiW2UWK9JskMdq3JI4789pgjAUAtik3FnCBlswPmYTOAAGBX6l3BCjIzcnOIgO/ SRle66zjLxMDbNutNkgxL7YVe1FrFc04r35beqs3HGUVTkIfPDHQw/czn2os+QVSa2zA D5GuU3TSxu3/V1JtcKAm6UhlfI8eK/GqCn6Y3md6Z+RPYPssWfsve7wjHdUHjFkDGd7P 8r4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=lJrIxmcZFZWmXNWrkV4FXt9Nks+3QcwwcMu4ZtUB2fI=; b=UXn37AV3QhfSnT9PZoL3sSrjnQKXxvRwu+dvWFI8LQB71wbZEpbIThdZ31iOQR+ikQ WPbbVgs5N4sspT5j4wSweUFBirMiQkqbZbaXgtjQzXpcIfdO1vOB2gHlY1oB22OCMYRE 6dA2TydMeDCeiaFJU8OIIZxNOdIhCf4f3KXMqi5SkL2wEjTrTHDDqU76MYfwtwEe4o1T Fsfso9kr9n0TWQIjashOXaizXVlctnfzc6NeDiKruExKIoidVIf1znEoYgNsqamNogHx 6WlCzfMoj068zop5EGisYvVniDCpzXdtZ/R+74eiNXoctNHik5wxA8Qhhb8/prNzyQ9k bCqA== X-Gm-Message-State: APjAAAXupV354CjB9uM2qatCNPgnV1tLw1hMhyXae8cLq0q3pkM3XYdZ ungIYI41VCujLzkOqPdLGKk2ig== X-Google-Smtp-Source: APXvYqx3yz1nurg6avRIoafu8FUTMSdOPivzeyd95O5QePHtj5l4DmxYtw/3FaebLQy7X1q9CceNow== X-Received: by 2002:aed:3f81:: with SMTP id s1mr2077354qth.94.1551409657100; Thu, 28 Feb 2019 19:07:37 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id n78sm3553326qkn.10.2019.02.28.19.07.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 19:07:36 -0800 (PST) Date: Thu, 28 Feb 2019 19:07:30 -0800 From: Jakub Kicinski To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: Re: [RFC v2 5/6] mlx4: report errors through extack Message-ID: <20190228190716.4ef22216@cakuba.netronome.com> In-Reply-To: <20190228215441.28275-6-stephen@networkplumber.org> References: <20190228215441.28275-1-stephen@networkplumber.org> <20190228215441.28275-6-stephen@networkplumber.org> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Feb 2019 13:54:40 -0800, Stephen Hemminger wrote: > @@ -2870,8 +2873,8 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) > if (port_up) { > err = mlx4_en_start_port(dev); > if (err) { > - en_err(priv, "Failed starting port %d for XDP change\n", > - priv->port); > + NL_SET_ERR_MSG_MOD(extack, > + "Failed starting port for XDP change"); alignment is off now in a few spots > queue_work(mdev->workqueue, &priv->watchdog_task); > } > }