From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18233C43381 for ; Thu, 28 Feb 2019 21:55:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7D8520675 for ; Thu, 28 Feb 2019 21:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="xfQjBZwL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733154AbfB1VzA (ORCPT ); Thu, 28 Feb 2019 16:55:00 -0500 Received: from mail-pg1-f181.google.com ([209.85.215.181]:33104 "EHLO mail-pg1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732812AbfB1Vyy (ORCPT ); Thu, 28 Feb 2019 16:54:54 -0500 Received: by mail-pg1-f181.google.com with SMTP id h11so10374846pgl.0 for ; Thu, 28 Feb 2019 13:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sLNwO6JW79FnQHH99Q2nrWLy/qLEaBWAO+cOjJ4X7os=; b=xfQjBZwLZKS1b/c4J2zK2LbeZN6LHXP2aEQT7dpgwbD/pnKbmJNQL4Nl2W2d3325CP P1fhbqqSvV4+H0QV0OaFP8hqjuzyYGq3HGqpQ368bW9Z7ON1OkxjlP4dM+x0y82pxoZZ nQY1aYIZeMWAwqtmbSJZeERkqS1NwA2rz8+T+5uzgCRxKOODt+Zgd5Kgs/Mo/zOJvWoB ElC3H3sSPbgg0K7Wd2SPV+P7FPROHOtJD5sxU0l99GDFmuL6zWAIay0Yl34sIGWOxLgt koYCPdGRHhbzQq9wAIqjg5fh5vwnOFosHRqW8m0n4JIl+26RPkaF0uI5bNWK4IKpanh9 uc2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sLNwO6JW79FnQHH99Q2nrWLy/qLEaBWAO+cOjJ4X7os=; b=NMwedFcsrQXyS5nHHPmrUVJiam4MQRapLk2tbrkzeOMihUEng1f9hdMVrRpnxxXl8x mdS6V0b6b7Sw0Iha4i88ZTzX3yTz4calbvlA5SRsb5GAvcKTRDR7fW1svsxVIMn2lCyX 6/zKuhQZZ7rnrHQ73DYi64QHNAKx72ZqfYm9mJ40x44ss5PeD+j2Zcr3IuJ3EeQgW5Ia FljKLbAwXsT5azujy/P3Kx8ZHr/bJZipTqMIQIsyBwDxSBneIyYBCfopGBZwH/6cCIh+ Nah0Avzv2tMYMo8g295A3xTbQq6s/rB6zjXVu7CNB6vtQCOYCGdLqpr+dwOal4FdSUWm CLDg== X-Gm-Message-State: APjAAAX6BK+vhZ2LnmXkexv5O0fbSYN2Y8Svh4UgezuWoPbgrq02F7SG Y/t8zjvlj6cjIl432q3H4a1Wvx3AHR4= X-Google-Smtp-Source: AHgI3IaOHr37svnSUNrvgjdB93LyYBZjjZZMUIWWn0KaUs3csMBsIlFCw+Sx1140pb8iRgbAbF36Ew== X-Received: by 2002:a62:1981:: with SMTP id 123mr1841310pfz.69.1551390893405; Thu, 28 Feb 2019 13:54:53 -0800 (PST) Received: from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b138sm40078643pfb.48.2019.02.28.13.54.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Feb 2019 13:54:52 -0800 (PST) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [RFC v2 5/6] mlx4: report errors through extack Date: Thu, 28 Feb 2019 13:54:40 -0800 Message-Id: <20190228215441.28275-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190228215441.28275-1-stephen@networkplumber.org> References: <20190228215441.28275-1-stephen@networkplumber.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org XDP errors should be reported via extack (back to command) rather than on console. Signed-off-by: Stephen Hemminger --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c index c1438ae52a11..75ae06c82294 100644 --- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c +++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c @@ -2779,7 +2779,8 @@ static int mlx4_en_set_tx_maxrate(struct net_device *dev, int queue_index, u32 m return err; } -static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) +static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog, + struct netlink_ext_ack *extack) { struct mlx4_en_priv *priv = netdev_priv(dev); struct mlx4_en_dev *mdev = priv->mdev; @@ -2816,8 +2817,10 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) return 0; } - if (!mlx4_en_check_xdp_mtu(dev, dev->mtu)) + if (!mlx4_en_check_xdp_mtu(dev, dev->mtu)) { + NL_SET_ERR_MSG_MOD(extack, "MTU exceeds support XDP maximum"); return -EOPNOTSUPP; + } tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); if (!tmp) @@ -2870,8 +2873,8 @@ static int mlx4_xdp_set(struct net_device *dev, struct bpf_prog *prog) if (port_up) { err = mlx4_en_start_port(dev); if (err) { - en_err(priv, "Failed starting port %d for XDP change\n", - priv->port); + NL_SET_ERR_MSG_MOD(extack, + "Failed starting port for XDP change"); queue_work(mdev->workqueue, &priv->watchdog_task); } } @@ -2908,11 +2911,12 @@ static int mlx4_xdp(struct net_device *dev, struct netdev_bpf *xdp) { switch (xdp->command) { case XDP_SETUP_PROG: - return mlx4_xdp_set(dev, xdp->prog); + return mlx4_xdp_set(dev, xdp->prog, xdp->extack); case XDP_QUERY_PROG: xdp->prog_id = mlx4_xdp_query(dev); return 0; default: + NL_SET_ERR_MSG_MOD(xdp->extack, "Unsupported XDP command"); return -EINVAL; } } -- 2.17.1