From: David Miller <davem@davemloft.net>
To: hkallweit1@gmail.com
Cc: linux@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 net] net: phy: phylink: fix uninitialized variable in phylink_get_mac_state
Date: Fri, 01 Mar 2019 11:31:31 -0800 (PST) [thread overview]
Message-ID: <20190301.113131.1752709783119341823.davem@davemloft.net> (raw)
In-Reply-To: <49e5b548-b82e-a975-20e4-051c0c634a6c@gmail.com>
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Tue, 26 Feb 2019 19:29:22 +0100
> When debugging an issue I found implausible values in state->pause.
> Reason in that state->pause isn't initialized and later only single
> bits are changed. Also the struct itself isn't initialized in
> phylink_resolve(). So better initialize state->pause and other
> not yet initialized fields.
>
> v2:
> - use right function name in subject
> v3:
> - initialize additional fields
>
> Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2019-03-01 19:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 18:29 [PATCH v3 net] net: phy: phylink: fix uninitialized variable in phylink_get_mac_state Heiner Kallweit
2019-03-01 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301.113131.1752709783119341823.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox