From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SU7t=RF=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E3725C43381
	for <netdev@archiver.kernel.org>; Sat,  2 Mar 2019 05:37:30 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id B04F020836
	for <netdev@archiver.kernel.org>; Sat,  2 Mar 2019 05:37:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727691AbfCBFh3 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Sat, 2 Mar 2019 00:37:29 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:34948 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725930AbfCBFh3 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 2 Mar 2019 00:37:29 -0500
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 5ED7E144DC6C4;
        Fri,  1 Mar 2019 21:37:28 -0800 (PST)
Date:   Fri, 01 Mar 2019 21:37:27 -0800 (PST)
Message-Id: <20190301.213727.1911789008106427849.davem@davemloft.net>
To:     hkallweit1@gmail.com
Cc:     vivien.didelot@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: prevent interrupt storm
 caused by mv88e6390x_port_set_cmode
From:   David Miller <davem@davemloft.net>
In-Reply-To: <a5840acf-e0ca-633d-93a4-91fa6cd42c09@gmail.com>
References: <a5840acf-e0ca-633d-93a4-91fa6cd42c09@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 01 Mar 2019 21:37:28 -0800 (PST)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Thu, 28 Feb 2019 07:39:15 +0100

> When debugging another issue I faced an interrupt storm in this
> driver (88E6390, port 9 in SGMII mode), consisting of alternating
> link-up / link-down interrupts. Analysis showed that the driver
> wanted to set a cmode that was set already. But so far
> mv88e6390x_port_set_cmode() doesn't check this and powers down
> SERDES, what causes the link to break, and eventually results in
> the described interrupt storm.
> 
> Fix this by checking whether the cmode actually changes. We want
> that the very first call to mv88e6390x_port_set_cmode() always
> configures the registers, therefore initialize port.cmode with
> a value that is different from any supported cmode value.
> We have to take care that we only init the ports cmode once
> chip->info->num_ports is set.
> 
> v2:
> - add small helper and init the number of actual ports only
> 
> Fixes: 364e9d7776a3 ("net: dsa: mv88e6xxx: Power on/off SERDES on cmode change")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, and queued up for -stable.

Thanks.