From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3992AC43381 for ; Fri, 1 Mar 2019 07:33:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E8D522186A for ; Fri, 1 Mar 2019 07:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="RBlr1pM7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732448AbfCAHc7 (ORCPT ); Fri, 1 Mar 2019 02:32:59 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39335 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbfCAHc7 (ORCPT ); Fri, 1 Mar 2019 02:32:59 -0500 Received: by mail-wr1-f66.google.com with SMTP id l5so24706422wrw.6 for ; Thu, 28 Feb 2019 23:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9seTCOpoJGiiWZQXn4T9KqHjE5K1hg9VZMKsP2PU9K4=; b=RBlr1pM7UkcfR+o9RvjBppwNokTbHAO9j0HQ4OwDwuScBeXIzRmFrnEIPEfugSOaRj Lmj/yZPgKtshEe4NietFVbRsn9VDNmCllxZmekv8jze/X9LaUueKHxwjPIJvMBnbxbmg XszWNREKDtC3TH79IRIRtz73TO82Kd2Fks5ryFMJW3gY2jo3neDzCwjiDuUMOXHx3MRS 3DHUMQLkUEkboaCUgiAuUrLkIVMYYIY0bDAojF64OJIRjHO8Zpzi7xbtapZwUp3GEgVY +VEI7/Bdla92sTTJrkm2XzQEoRMuUlbxnwmYEeY7RG6dKgI6xmH8k68jJIpjxo8xuzyj L4pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9seTCOpoJGiiWZQXn4T9KqHjE5K1hg9VZMKsP2PU9K4=; b=nOY7ejY5p//0sxru0qdJj2zE9D7BR9CeH3eCNOFFkG52HgPpvetu1xMTFBdQhAcDn7 keVwycbmM6N03ysSM5hmW21JDOmqVGqk8fnr8Wx9jQv4p5Z/HGvrAt75RwE3ivFS1qEK uwJFrT8d6WhhKYmzW7YQ2V+zlmvKp9duqc0dy6ZzX8TX3+vXWGeJD4R/ongkBqY0C5f1 JwWJnXK5h+2+NPC/07j248oq/SjZSVoWoHB42jhxPz/9GMZ65qgMv91s+2pCtpd4X4kS HHcTR253viox55wQOJJWKam1uYzwGmOPXVH2fsFlwZE8ad3xtMQUexsCNdj4H8KR1rbF jU8Q== X-Gm-Message-State: APjAAAWpBXLDST738pDn2P6wvy+DZkJiYm4RLYG9xMH98bVsgpxv1xq4 /Dhus2OWrsHcSzX9YTdJoAErbQ== X-Google-Smtp-Source: APXvYqxMWQWNDCi+v4I6Is+ydcYc+e77YdPywzGRG7oLO83AvfCwTzQWJtv2YuV6JDNQg3hHZMvDyg== X-Received: by 2002:adf:f691:: with SMTP id v17mr2386671wrp.66.1551425577694; Thu, 28 Feb 2019 23:32:57 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id w10sm17330125wrn.32.2019.02.28.23.32.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 28 Feb 2019 23:32:57 -0800 (PST) Date: Fri, 1 Mar 2019 08:23:04 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, mkubecek@suse.cz, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v4 1/6] net: devlink: turn devlink into a built-in Message-ID: <20190301072304.GF2314@nanopsycho> References: <20190226033407.32625-1-jakub.kicinski@netronome.com> <20190226033407.32625-2-jakub.kicinski@netronome.com> <20190228150125.GB2462@nanopsycho> <20190228080256.773f4f19@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190228080256.773f4f19@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Feb 28, 2019 at 05:02:56PM CET, jakub.kicinski@netronome.com wrote: >On Thu, 28 Feb 2019 16:01:25 +0100, Jiri Pirko wrote: >> Tue, Feb 26, 2019 at 04:34:02AM CET, jakub.kicinski@netronome.com wrote: >> >diff --git a/net/Kconfig b/net/Kconfig >> >index 62da6148e9f8..1efe1f9ee492 100644 >> >--- a/net/Kconfig >> >+++ b/net/Kconfig >> >@@ -429,21 +429,12 @@ config NET_SOCK_MSG >> > with the help of BPF programs. >> > >> > config NET_DEVLINK >> >- tristate "Network physical/parent device Netlink interface" >> >+ bool "Network physical/parent device Netlink interface" >> >> Wouldn't "default y" be better? > >No opinion. It used to be 'n', it didn't change here.. But we can >change if we write convincing enough commit message :) > >Did you see cases where people "forget" to enable it? I just did :) But I believe that is what's going to happen in the future. > >> > help >> > Network physical/parent device Netlink interface provides >> > infrastructure to support access to physical chip-wide config and >> > monitoring. >> > > >