From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4BAC43381 for ; Fri, 1 Mar 2019 16:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6DBA20675 for ; Fri, 1 Mar 2019 16:04:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PMlcFIBF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388321AbfCAQEL (ORCPT ); Fri, 1 Mar 2019 11:04:11 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:36256 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727952AbfCAQEL (ORCPT ); Fri, 1 Mar 2019 11:04:11 -0500 Received: by mail-qt1-f195.google.com with SMTP id p25so28322744qtb.3 for ; Fri, 01 Mar 2019 08:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=eUabpn//ZNRdh7yJF0Cte8epdM+F9tST4Vrm0GmJDMM=; b=PMlcFIBF18S2B9D8FWpb4XpSqbKPulKva6XaC2Ce8bM8PolxbBtzVJhzZ2Bmdb7i4T 1/8vetz9kFQ9h/E0BdaaI0SwrHEn04Wyv1PxeynAsFRGrh9h75NYtT856VVJxIc796Oe FIFG2LuCUXL19JiAkTpNmdfROhvtHTA7FWg0cmDwmUGnYi613BW0vs/iVhzaM9n7IB0j ns3KWx6FaNeXMN/EotQfy1qqTX5K+oIIzVyWcwNJ894MKT/3Ben1HVZWZzi/p4vgQOPi Tx3O4JRMRvVjXX0yNqMri4nPc7SiYTqPyM5+RNtha0pYY8Kop0fORDGPgLXP1KlRz/oN +OUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=eUabpn//ZNRdh7yJF0Cte8epdM+F9tST4Vrm0GmJDMM=; b=pxWtXRnZmSDIraiT9S3MmbKP60vp0rnYP8eGTH8emXwGk6Bv6Lx4EkFET5J9Hg9Vt5 a3jMtjOs7ZBnAuOOv6qDdsHcydK7EK8HCLq5SJIoinHnH6R8zknSGpwnub1t/KDBFx7R xGcnzaz4z+PLYEvniM2u/WgYRENAbuRGfNr1OsuXJouFrT7Q4ljbF0KWnPGmiXyU4hKn RnLYapkwxe0bikAeKf6umFxGuH/j+swxVh2/QxrGId+DSx6cxLWeNUYcgB8SMdGj8LzI b172HqSAqsk4eafwo3rmPFFu0GG0NsWtCB1974sJ2sePEt1ahpxQao+Rdt5AKiitYZMD egpQ== X-Gm-Message-State: APjAAAUbgKcWdwoxwZ/yhhoKz1OGiTVpzRWxo3y5WB9EXOu1u3/5tRJY PPKTiMYj1Sax1DysH/78PrJa4klQO60= X-Google-Smtp-Source: APXvYqyF8R3LVGZ2aNRq8ARBGpg5jfCBWegzZJOcL9TjFwEKaOJSPca4Op83u3mQpIEtymcvIYgFqw== X-Received: by 2002:aed:3f5d:: with SMTP id q29mr4337857qtf.193.1551456250262; Fri, 01 Mar 2019 08:04:10 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id s5sm6627084qkf.87.2019.03.01.08.04.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 08:04:10 -0800 (PST) Date: Fri, 1 Mar 2019 08:04:01 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, parav@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports Message-ID: <20190301080401.1b860467@cakuba.netronome.com> In-Reply-To: <20190301072557.GG2314@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-5-jakub.kicinski@netronome.com> <20190227123753.GB2240@nanopsycho> <20190227103000.6ea6f7c0@cakuba.netronome.com> <20190228085624.GD2324@nanopsycho.orion> <20190228082404.5b6d1061@cakuba.netronome.com> <20190301072557.GG2314@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Mar 2019 08:25:57 +0100, Jiri Pirko wrote: > >> I think it would be beneficial to have the switchid shown for devlink > >> ports too. Then it is clean that the devlink ports with the same > >> switchid belong to the same switch, and other ports under the same > >> devlink instance (like PF itself) is separate, but still under the same > >> ASIC. > > > >Sure, you mean in terms of UI - user space can do a link dump or get > >that from sysfs, right? > > I thinking about moving it to devlink. I'll work on it more today. At the kernel level? Are we sure this is appropriate? I'd think switchid is in essence a forwarding attribute, so it belongs with netdevs, no?