From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05A2AC43381 for ; Fri, 1 Mar 2019 16:06:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C75892085A for ; Fri, 1 Mar 2019 16:06:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="PikAv0Ga" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388984AbfCAQF7 (ORCPT ); Fri, 1 Mar 2019 11:05:59 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:33860 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388974AbfCAQF5 (ORCPT ); Fri, 1 Mar 2019 11:05:57 -0500 Received: by mail-qt1-f193.google.com with SMTP id w4so28370291qtc.1 for ; Fri, 01 Mar 2019 08:05:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=1VQPT3r7Q4kPNWk/vHsWTFoW9Bm2v8fu5grCL3W1UTs=; b=PikAv0Ga89CB86pKRqCAe7AYPBAKjKEE/rO4E317Wc+b0UHMWCQcDdaGg9NzA4ZK7A 0QsRWzZ07BnvarLjP+KNSx2SlHAyNvRle0drMe1wVnNp9asdM0iPgC3mo1PUA/LLB4dQ KEoq1DQYRcN/kSG46OJQD26o/7PjB/znXOWvEQPJb078lhbYvmAATTgMa5MmJiX7USR1 vIZ6JGR4g+NJGZJIhXL/0x6xt+po2QqkaD4SNGabZ11yOQrYFHFxvA1PvmXkOzAMIUPH r/qZkaDNFA2RDUYihytdJ5aqZj4DD1rcRQc7Ll9kNnS5499UsUVy3aO9LodyXMvzmlo7 s7Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=1VQPT3r7Q4kPNWk/vHsWTFoW9Bm2v8fu5grCL3W1UTs=; b=jmZ+pDA1Qfjhg3CmN2fO/d4ZIuzFWUQAvG5XYiD2Y7neJug1pVRD6CTKeQ6RtzsG6W Ht9C5k+yTj6i+9mwGiXhPW+A1FC6y6QtJuWEd5i6Y5rbsOqUZGmVic+mPt4NnNy1KC2I mJEs+Elg+Lj32TjY0R+HUFQuuXOieTwh5rpvShkkNuEFl52vy4Vz7xSSA8UwWCRpRKPo ho+P0F15xPOuW5Zbdp5PHzWKUMhAkXar2ItvOQpz+m3lsL0FYgoxX8eDsNiM4rV3Y1aC x2gT5DU2fsouomzE9hV+aW3KFmbZ2mycUV946DXtSmFF9PKFhg00Yv3n3Kj3Sl29fFBP b/tQ== X-Gm-Message-State: APjAAAU26yNqMSU4HEFzLOe2whC3wSZaNy1SHwBMXYn/lDErOdAEP4sD 5ocWBcEBm4MpJkbDHviD7CqoyQhrvSM= X-Google-Smtp-Source: APXvYqwfN3cLe2MHDJZtK40/KLv9F8ShXXXUav5LQRazsbFbUHAt1wKgAiLyFS+tfHFxoXWtnMU0dg== X-Received: by 2002:a0c:be91:: with SMTP id n17mr4434395qvi.32.1551456356106; Fri, 01 Mar 2019 08:05:56 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id v26sm13813743qtk.22.2019.03.01.08.05.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 08:05:55 -0800 (PST) Date: Fri, 1 Mar 2019 08:05:47 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next 6/8] devlink: introduce port's peer netdevs Message-ID: <20190301080547.09cc0a9a@cakuba.netronome.com> In-Reply-To: <20190301073700.GH2314@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-7-jakub.kicinski@netronome.com> <20190227130829.GC2240@nanopsycho> <20190227104742.3897ae1a@cakuba.netronome.com> <20190228090054.GE2324@nanopsycho.orion> <20190228083644.1387fb7a@cakuba.netronome.com> <20190301073700.GH2314@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 1 Mar 2019 08:37:00 +0100, Jiri Pirko wrote: > >> >I do not think that every netdev should have a devlink port associated. > >> > > >> >> Not sure about VF. > >> >> > >> >> Consider a simple problem of setting up a VF mac address. In legacy, you > >> >> do it like this: > >> >> $ ip link set eth2 vf 1 mac 00:52:44:11:22:33 > >> >> However, in new model, you so far cannot do that. > >> > > >> >Why? > >> > > >> >$ devlink port set pci/0000:82:00.0/10001 peer_eth_addr 00:52:44:11:22:33 > >> > >> Yeah. That is not yet implemented. I agree it is most straightforward. > >> The question is, is it fine to have set of: > >> peer_eth_addr > >> peer_mtu > >> peer_something_else > >> Or rather to have some object to pin this on. Something like: > >> > >> $ devlink port peer set pci/0000:82:00.0/10001 eth_addr 00:52:44:11:22:33 > > > >I do like the object one better, would this mean I should restructure > >the peer stuff somehow (netlink attribute structure)? > > Well we can introduce separate commands: > DEVLINK_CMD_PORT_PEER_GET > DEVLINK_CMD_PORT_PEER_SET > > For "set" part, this would work nice. However for the "get" part, we > would have to call both DEVLINK_CMD_PORT_GET and > DEVLINK_CMD_PORT_PEER_GET. So probably better to add a nest attr: > DEVLINK_ATTR_PORT_PEER > and have attrs like: > DEVLINK_ATTR_PORT_PEER_HW_ADDR (does not have to be always eth, right?) > DEVLINK_ATTR_PORT_PEER_TYPE (DEVLINK_PORT_TYPE_NOTSET/DEVLINK_PORT_TYPE_ETH/DEVLINK_PORT_TYPE_IB) > DEVLINK_ATTR_PORT_PEER_NETDEV_IFINDEX > DEVLINK_ATTR_PORT_PEER_NETDEV_NAME > DEVLINK_ATTR_PORT_PEER_NETDEV_IBDEV_NAME > in the nest. > > The userspace part can stay as I described previously: > $ devlink port peer set pci/0000:82:00.0/10001 hw_addr 00:52:44:11:22:33 > > Not sure about "port show" output. In json, the "peer" things should be > under "peer" dictionary. I'll make it so.