From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDB1C43381 for ; Fri, 1 Mar 2019 13:27:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 556DD2084D for ; Fri, 1 Mar 2019 13:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728257AbfCAN1d (ORCPT ); Fri, 1 Mar 2019 08:27:33 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:40070 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726416AbfCAN1d (ORCPT ); Fri, 1 Mar 2019 08:27:33 -0500 Received: by mail-qk1-f194.google.com with SMTP id h28so14231725qkk.7 for ; Fri, 01 Mar 2019 05:27:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wVY+mrRZeRj7xu0Fgn9E2eqOQg/Qib2NU7G37hPzTCw=; b=bH0KKUO+seXInXZvUa4vMJ6shZPyKP/Jx+LC5bd5SgvocSLD2l9xSk4V2uJqQBSX+7 Sqf4SIvn278EzlvEHVkWTBTKqMhQH3fBtOM3ZnOGREelcYek6cKApw5j8NuEBQCxSCJj czH/z438pqyn/+4jwhNK2IUPemQbpeu5MTUonCaobMI25/wGAhdDZKUtqjBvoTNw8vQ/ rsDmPIC3nYWKrhnLOiKIo/xGuLHGeSLxK8FJFC7475ENkuX28ODMdnSq+p7O+zOp7szl W5yvAtrfxp5qGQQAdiD3e0nWPrbq2D+Sqm/OzNfnwrkX/XTwrNrFRpnc2bTheYz78UUA iQEQ== X-Gm-Message-State: APjAAAUWYvUji9uYPbqGmxyMYnVpiQVzdSRf1KhteHJsY+lBS7jbf1cr LuXp5WztObV4r/feUgkxpIciWg== X-Google-Smtp-Source: APXvYqzTPdyF0+USUPsFn98BP15vTs/GIQS0rfretLknn6Js0A7zEvW4pu1MpappuAvsSmDTPpiVOw== X-Received: by 2002:a37:3641:: with SMTP id d62mr3775174qka.14.1551446851573; Fri, 01 Mar 2019 05:27:31 -0800 (PST) Received: from redhat.com (pool-173-76-246-42.bstnma.fios.verizon.net. [173.76.246.42]) by smtp.gmail.com with ESMTPSA id r22sm13672324qki.43.2019.03.01.05.27.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 05:27:30 -0800 (PST) Date: Fri, 1 Mar 2019 08:27:28 -0500 From: "Michael S. Tsirkin" To: si-wei liu Cc: "Samudrala, Sridhar" , Siwei Liu , Jiri Pirko , Stephen Hemminger , David Miller , Netdev , virtualization@lists.linux-foundation.org, virtio-dev , "Brandeburg, Jesse" , Alexander Duyck , Jakub Kicinski , Jason Wang , liran.alon@oracle.com Subject: Re: [virtio-dev] Re: net_failover slave udev renaming (was Re: [RFC PATCH net-next v6 4/4] netvsc: refactor notifier/event handling code to use the bypass framework) Message-ID: <20190301082448-mutt-send-email-mst@kernel.org> References: <20190225210529-mutt-send-email-mst@kernel.org> <20190227173710-mutt-send-email-mst@kernel.org> <20190227184601-mutt-send-email-mst@kernel.org> <20190227193923-mutt-send-email-mst@kernel.org> <36901346-e3d5-4e51-6a8d-678eb5b9e352@oracle.com> <20190228091119-mutt-send-email-mst@kernel.org> <8a387954-1e21-947b-a5a9-c49adaea2e81@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a387954-1e21-947b-a5a9-c49adaea2e81@oracle.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Feb 28, 2019 at 05:30:56PM -0800, si-wei liu wrote: > > > On 2/28/2019 6:26 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 28, 2019 at 01:32:12AM -0800, si-wei liu wrote: > > > > > Will the > > > > > change break userspace further? > > > > > > > > > > -Siwei > > > > Didn't you show userspace is already broken. You can't "further > > > > break it", rename already fails. > > > It's a race, userspace tends to give slave a user(space) desired name but > > > sometimes may fail due to this race. Today if failover master is not up, > > > rename would succeed anyway. While what you proposed prohibits user from > > > providing a name in all circumstances if I understand you correctly. That's > > > what I meant of breaking userspace further. On the other hand, you seem to > > > tighten the kernel default naming to udev predictable names, which is > > > derived from only recent systemd-udevd, while there exists many possible > > > userspace naming schemes out of that. Users today who deliberately chooses > > > to disable predictable naming (net.ifnames=0 biosdevname=0) and fall back to > > > kernel provided names would expect the ethX pattern, with this change > > > admin/user scripts which matches the ethX pattern could potentially break. > > Whatever crashes with a name not matching ethX will crash on the > > standby interface *anyway*. > With udev predictable naming disabled they should not. It's not hard for > user to look for device attribute to persistent the name well, in a > consistent and reliable way. Well that's special code for failover already. So far we just taught userspace to skip renaming slave interfaces. > > > > So I think what you are saying is that someone might have already > > written scripts and gotten them to work on v4.17 when STANDBY was > > included and these scripts rely on ethX. Now these scripts > > will break. > The controversial part is the new kernel naming pattern. Initially I thought > there shouldn't be such crazy scripts relying on the pattern, but when I > worked on cloud-init it I realized that there's already a lot of software > taking assumption around the 'eth0' name. In the past I've seen random > scripts that parses the ethX name assumes (incorrectly) the name ends up > with digits, or even the digits and name are 1:1 mapped. Of course, you can > say these are bugs in scripts themselves. No what I say is that they will crash on rename of standby too. > Anyway, I'll let others in the netdev to comment on this new scheme, maybe > that's the concern of merely myself. The good part of your proposal is that > we can get consistent slave name, which still plays its role until we move > towards making slave names less relevant, i.e. ideally a 1-netdev model. I > think we both agree that the master matters more than the slave names. > > > > Maybe it is still early enough (just half a year passed) that the > > number of these users would be small. So how about a kernel config > > option and maybe a module parameter to rename the primary? People can > > then opt in to the old broken behaviour. > Were I could I would ask why a similar opt-in (kernel config or module > parameter) couldn't be implemented to open up the rename restriction on > slave, net_failover in particular. What I felt about this rename restriction > was more because of historical reason than anything else, while net_failover > is comparatively a new type of link that we are now designing proper use > case it should support, and can get it shaped to whatever it fits. My > personal view is that the slave can't be renamed when master is running is > just implementation details that got incorrectly exposed to userspace apps > for many years. It's old behavior with historical reason for sure, but I > don't think this applies to net_failover. > > (FWIW as one previous bond maintainer for another OS, we relieved the rename > restriction slaves 13 year ago, while no single complaint or issue was ever > raised because of this change over the years, neither from the customers of > tens of millions of installation base, nor the FOSS software running atop. > Of course, Linux is different so that experience doesn't count.) > > Thanks, > -Siwei >