* [PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe
@ 2019-03-01 10:37 Arjun Vynipadath
2019-03-02 7:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arjun Vynipadath @ 2019-03-01 10:37 UTC (permalink / raw)
To: netdev, davem; +Cc: nirranjan, indranil, dt, Arjun Vynipadath, Vishal Kulkarni
netif_carrier_off() should be called only after register_netdev().
Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 3dac7579d5a0..d22df0f6c088 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -3140,7 +3140,6 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
* it.
*/
pi->xact_addr_filt = -1;
- netif_carrier_off(netdev);
netdev->irq = pdev->irq;
netdev->hw_features = NETIF_F_SG | TSO_FLAGS | NETIF_F_GRO |
@@ -3246,6 +3245,7 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
continue;
}
+ netif_carrier_off(netdev);
set_bit(pidx, &adapter->registered_device_map);
}
if (adapter->registered_device_map == 0) {
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe
2019-03-01 10:37 [PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe Arjun Vynipadath
@ 2019-03-02 7:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-02 7:21 UTC (permalink / raw)
To: arjun; +Cc: netdev, nirranjan, indranil, dt, vishal
From: Arjun Vynipadath <arjun@chelsio.com>
Date: Fri, 1 Mar 2019 16:07:01 +0530
> netif_carrier_off() should be called only after register_netdev().
>
> Signed-off-by: Arjun Vynipadath <arjun@chelsio.com>
> Signed-off-by: Vishal Kulkarni <vishal@chelsio.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-02 7:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 10:37 [PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe Arjun Vynipadath
2019-03-02 7:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).