From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E839C43381 for ; Fri, 1 Mar 2019 11:31:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 598EB2085A for ; Fri, 1 Mar 2019 11:31:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qTLyfDfS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733102AbfCALbY (ORCPT ); Fri, 1 Mar 2019 06:31:24 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:39223 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbfCALbY (ORCPT ); Fri, 1 Mar 2019 06:31:24 -0500 Received: by mail-pl1-f194.google.com with SMTP id b65so8339595plb.6 for ; Fri, 01 Mar 2019 03:31:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PzBnUKCMpqhXBrUK5c+OOJt1NnDC4JFMtptl9Yt/mqQ=; b=qTLyfDfS/WIvNphgDf+m7yQtz9kvM86lSzRtLQcDIGhjBO78H3KoKHWt/PKAvwRobz dwohhgnl/TDXZa5uC/lA8fvcH3ctz61afqvt0ZKmJnLtoNreo/exg9QqxcR3H73XF115 k7JJH0Mb3ElnD8E98Pdsjap7QpDQ5wUJlr5y0FeqBfT50Bjm4iktQGYDYwXs309yipzw nzPK1VMv/yer9onLputc1jFufNjLzVvcqHSwRhuCLOKVw6eQYNjetJ86ZjQWOfNEze6n +MMM301YiYO3Y08fIp7JS9G9QS4Hlv6Fqn+12eIkKaB9KKxEJNO/WjPPOrqQ4R0/CEIS J8PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PzBnUKCMpqhXBrUK5c+OOJt1NnDC4JFMtptl9Yt/mqQ=; b=L8lrVJeC/USou0IHAEwW16GdBx2ESQJ1Pk1APa7jdK4l5mckzbBvImL9nWrXx6egjs fv1lqgz69p/EYzjta7PbJ4ge0lXUC/2boAwgupNjb9ErkeDkwXfr9O0q5LNlIwovWqc0 cTFJXSppQVZLRf2EuiEVOitaeKqEDwImMOPibXIe7mgKwGkMC9TC1LTOoPAYi/nRREYw 6rM12JPNkJEzgoFw0h9/VXGKdxY99Us4HsyZ9rn7+2hHquwbWvtgGAWDuVQuXIv6ZSrD E0LCHNt06ZV2NTmht4EqLh89C0LJUHd9EKbgxYibJI87/qE46hxPapvvD4KJL6v7jdSg 6+VQ== X-Gm-Message-State: APjAAAWBxhGEh3sYIb88j6+COGzqe/xDEOBPLOCR0o2FfcXtyRSR1gma GKE+wUYkhgxHUC7qQtBmy4TAQCI94aw= X-Google-Smtp-Source: APXvYqz+4FCrF4dAPjCn8wUy3EsvRLxdGHxMVIfanznaXZF395ENjtQ7eIB00SRkcgRT+qn9010mKg== X-Received: by 2002:a17:902:b492:: with SMTP id y18mr4893346plr.175.1551439883933; Fri, 01 Mar 2019 03:31:23 -0800 (PST) Received: from localhost (fmdmzpr04-ext.fm.intel.com. [192.55.54.39]) by smtp.gmail.com with ESMTPSA id r86sm20459937pfa.82.2019.03.01.03.31.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 03:31:23 -0800 (PST) Date: Fri, 1 Mar 2019 12:31:08 +0100 From: Maciej Fijalkowski To: Jakub Kicinski Cc: Stephen Hemminger , netdev@vger.kernel.org Subject: Re: [RFC v2 3/6] i40e: use extack for bpf errors Message-ID: <20190301122958.000034ba@gmail.com> In-Reply-To: <20190228190645.34c21d8b@cakuba.netronome.com> References: <20190228215441.28275-1-stephen@networkplumber.org> <20190228215441.28275-4-stephen@networkplumber.org> <20190228190645.34c21d8b@cakuba.netronome.com> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 28 Feb 2019 19:06:45 -0800 Jakub Kicinski wrote: > On Thu, 28 Feb 2019 13:54:38 -0800, Stephen Hemminger wrote: > > @@ -12140,12 +12144,14 @@ static int i40e_xdp(struct net_device *dev, > > struct i40e_netdev_priv *np = netdev_priv(dev); > > struct i40e_vsi *vsi = np->vsi; > > > > - if (vsi->type != I40E_VSI_MAIN) > > + if (vsi->type != I40E_VSI_MAIN) { > > + NL_SET_ERR_MSG_MOD(xdp->extack, "XDP not allowed on VF"); > > Is that right? Intel tends to have separate drivers for VFs, I think > the i40evf got renamed to iavf. > Good catch, this sanity check is to make sure that XDP is being enabled on main VSI of PF, not for example the VSI dedicated for Flow Director management (I40E_VSI_FDIR). Besides that, vsi->type != I40E_VSI_MAIN doesn't yield the I40E_VSI_SRIOV type. So it would be better to have an error message like "XDP is not allowed on VSIs other than main VSI". Thoughts? > I think it would be a good idea to CC maintainers on the driver patches. > > > return -EINVAL; > > + } > > >