From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADF5C43381 for ; Fri, 1 Mar 2019 13:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 041A620842 for ; Fri, 1 Mar 2019 13:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="rkca8z4A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388133AbfCANwj (ORCPT ); Fri, 1 Mar 2019 08:52:39 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45136 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387877AbfCANwi (ORCPT ); Fri, 1 Mar 2019 08:52:38 -0500 Received: by mail-wr1-f65.google.com with SMTP id w17so25928578wrn.12 for ; Fri, 01 Mar 2019 05:52:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZgV952G7sqfE8bHwOtBZmt2FxYoSzwwc+6dscyfFUPQ=; b=rkca8z4AOOkJwGcIQZGx438zSAzGozPgvHx54mNoXmZPDHu0Gu0FgmD2PWrG2uY0Co nP77wLe+x1p1RKndpqKAyeK6qY4Zm28DVK4KastIEtjfTLtvF+7j3LjfTIvqiLQKzeWI ZCD1oQXvqduc749R3JO5jY6J/Z9L45EFhvbU1jUYsisnbUHhmGho4CnzSeokkes/fDxN bvlyz59aii1Jz2yEcvFCpDeR0cjlKSF2lL385pYOf/+2F0llO7IdUiisjGJsobbZrbm8 WYJ3BmaEw4rp8ka6URCIaZss39vM3mPg3072Qr9D39Pq6AEsqBvckwjLYCfFEX8tlIDY Z08w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZgV952G7sqfE8bHwOtBZmt2FxYoSzwwc+6dscyfFUPQ=; b=ribs1waQJwZgxtjqqnBDt2lJi7sAV3fxRcpLvjNpKGEII6xiacSewwPuP3hmR1A4EK k9b+KsKK2KgX+8HptA8m28wtAB3Lb2qy8d0KPgpKkF2ETsJc2v8lM8GuAO9RXBTVMdgb HOFzPRZPeE2cIB1PNzAdgomZAflG6wMPNRrlcRGd47FuxtL9Julu8TlSsQqNyH13z84z 6G640xRoWAKCo0O568eMyeUOVWY6HFEHtDkrBxOLnxSpBbw+2JZfO7ZvGHm00dYZNteh c3J3KAszZxqchCobZCVLlEzBtIniBnyKhw7UcvNNAXWAvymHvisTjtX2Dv6+MFLZwmb8 Lc7w== X-Gm-Message-State: APjAAAXWtS0OHUsIOiF3uPXnXd2NNotG78Y26DunyY4YlFnRUw15HFo5 0CHDEvmDlHfkoE0SOkrUMH1OP68wkIqh9Q== X-Google-Smtp-Source: APXvYqyhSQ+qxfVKhs7IHi/ZLYiPXb3ZIEztv79OtipyaqpREBpPQ2J48r57K5GRcDmElZjQl+WBxQ== X-Received: by 2002:adf:ec8f:: with SMTP id z15mr3411634wrn.290.1551448356758; Fri, 01 Mar 2019 05:52:36 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id w10sm18523783wrn.32.2019.03.01.05.52.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 05:52:36 -0800 (PST) Date: Fri, 1 Mar 2019 14:42:43 +0100 From: Jiri Pirko To: Michal Kubecek Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next 1/5] net: replace ndo_get_devlink for ndo_get_devlink_port Message-ID: <20190301134243.GI2314@nanopsycho> References: <20190301081402.6074-1-jiri@resnulli.us> <20190301081402.6074-2-jiri@resnulli.us> <20190301124526.GF29992@unicorn.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301124526.GF29992@unicorn.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 01, 2019 at 01:45:26PM CET, mkubecek@suse.cz wrote: >On Fri, Mar 01, 2019 at 09:13:58AM +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Follow-up patch is going to need a devlink port instance according to >> a netdev. Devlink port instance should be always available when devlink >> is used. > >I noticed netdevsim has devlink interface but it does not register >devlink ports for its network devices. But that seems to be rather an >omission in netdevsim, right? Yep. > >> So change the recently introduced ndo_get_devlink to >> ndo_get_devlink_port. With that, adjust the wrapper for the only >> user to get devlink pointer. >> >> Signed-off-by: Jiri Pirko > >Reviewed-by: Michal Kubecek Thanks.