From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FDFC43381 for ; Fri, 1 Mar 2019 16:30:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E86C20850 for ; Fri, 1 Mar 2019 16:30:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="aXDkJq6B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389109AbfCAQaS (ORCPT ); Fri, 1 Mar 2019 11:30:18 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40177 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728449AbfCAQaS (ORCPT ); Fri, 1 Mar 2019 11:30:18 -0500 Received: by mail-wm1-f67.google.com with SMTP id g20so12020098wmh.5 for ; Fri, 01 Mar 2019 08:30:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=25rxGYlIk+vUKIdavoZBItDXfwJAIAa+4wFyDUoKgiU=; b=aXDkJq6Bco6lF7/LZ4ZNGzeYp0GjF1GC8e9CuI/WdpTRp8qe8e68RDgtfVp2DOQEyz SHRRbWLwd8mqcVBs2km1Z1OX7+T7BKgcHtNiAmPTL3YgoX8u6i4t74QyRatrL27Vr5GT XUs90XUojbfySoYt/gMQGOkOmYAep8ghLF1/3tS6VgtyUvjZ2pm5V3Ik9emE0aJ7DBaY 1foYroUdssdr2rrrgH7q4qlW5aLpLfJTRVNM9GlIleGJFz5xGjgqqqkgjJHIdsNe4NIJ avY+UMLH6i+ENDngTgCvBfwl9DQPl9qWN701DbXD/V+zYdGFW85nrKQJJjD9AVbssIx7 I/LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=25rxGYlIk+vUKIdavoZBItDXfwJAIAa+4wFyDUoKgiU=; b=j0cp2Z8xZdJuSg5rViMaGKptFBaptLrfs7TPAaFAxmAubOSkqIyGofEhxmnzJByX+l LLalYHQSB0SlGnkYx82SGexuecQBE97opG9N9Z9IjVqKuA5yeWPWqgezMAGbUJYtfi2J 5XJQJpY8unk/jfplTfSm4kWLHfGULsTkQ3cc51vWn/KJdZsQnmyNbO7tuyHx68hZ6o3k UgiDXROwoJe9CLadA6h44xKZ571BGFHdc3LURBj9U2+FWaHSOZ8CuXzKXP8BuYvLuT0N sUsNqUmHpjYX0DF0VAN3pI0Ipmd7xy1mYiSczbKHw0EJAJsoJduIYcBRNHnRklZ8ZztF qoJA== X-Gm-Message-State: APjAAAUFaF3aGaa/aQIpvrv8p0qIg2Fh5uIfHhCqLRvvzP2QgVxQjb5V XYcTRJuHRv0lXgRG2oXbjTWenA== X-Google-Smtp-Source: AHgI3IZng2q1q+jZqIK7nosVFJRJThBzqT5kGzVZ0iI/5fC/xgNYP/PGa01sscflQjAYFPvDXV31fg== X-Received: by 2002:a1c:ac87:: with SMTP id v129mr3982773wme.72.1551457816335; Fri, 01 Mar 2019 08:30:16 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id 2sm25411473wrg.89.2019.03.01.08.30.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 08:30:15 -0800 (PST) Date: Fri, 1 Mar 2019 17:20:23 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, oss-drivers@netronome.com, netdev@vger.kernel.org, parav@mellanox.com, jgg@mellanox.com Subject: Re: [PATCH net-next 4/8] devlink: allow subports on devlink PCI ports Message-ID: <20190301162023.GJ2314@nanopsycho> References: <20190226182436.23811-1-jakub.kicinski@netronome.com> <20190226182436.23811-5-jakub.kicinski@netronome.com> <20190227123753.GB2240@nanopsycho> <20190227103000.6ea6f7c0@cakuba.netronome.com> <20190228085624.GD2324@nanopsycho.orion> <20190228082404.5b6d1061@cakuba.netronome.com> <20190301072557.GG2314@nanopsycho> <20190301080401.1b860467@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301080401.1b860467@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 01, 2019 at 05:04:01PM CET, jakub.kicinski@netronome.com wrote: >On Fri, 1 Mar 2019 08:25:57 +0100, Jiri Pirko wrote: >> >> I think it would be beneficial to have the switchid shown for devlink >> >> ports too. Then it is clean that the devlink ports with the same >> >> switchid belong to the same switch, and other ports under the same >> >> devlink instance (like PF itself) is separate, but still under the same >> >> ASIC. >> > >> >Sure, you mean in terms of UI - user space can do a link dump or get >> >that from sysfs, right? >> >> I thinking about moving it to devlink. I'll work on it more today. > >At the kernel level? Are we sure this is appropriate? I'd think >switchid is in essence a forwarding attribute, so it belongs with >netdevs, no? It's an id which identifies ports which belong to the same switch. Internally in kernel it is used for forwarding purposes. But it is exposed to user too. I believe it is a nice way to see which devlink ports belong to switch and which not. Please see the RFC I send today.