From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com,
idosch@mellanox.com, dirk.vandermerwe@netronome.com,
f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com
Subject: Re: [patch net-next RFC 3/8] net: devlink: introduce devlink_compat_switch_id_get() helper
Date: Fri, 1 Mar 2019 17:40:51 +0100 [thread overview]
Message-ID: <20190301164051.GM2314@nanopsycho> (raw)
In-Reply-To: <20190301084515.5b378b37@cakuba.netronome.com>
Fri, Mar 01, 2019 at 05:45:15PM CET, jakub.kicinski@netronome.com wrote:
>On Fri, 1 Mar 2019 17:05:37 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@mellanox.com>
>>
>> Introduce devlink_compat_switch_id_get() helper which fills up switch_id
>> according to passed netdev pointer. Call it directly from
>> dev_get_port_parent_id() as a fallback when ndo_get_port_parent_id
>> is not defined for given netdev.
>>
>> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
>
>Here my locking concerns are even stronger :S Do you want to introduce
>some extra ordering rules regarding lifetime of devlink ports and their
>netdevs?
Working on it.
next prev parent reply other threads:[~2019-03-01 16:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 16:05 [patch net-next RFC 0/8] net: expose switch ID via devlink Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 1/8] net: devlink: convert devlink_port_attrs bools to bits Jiri Pirko
2019-03-02 2:48 ` Florian Fainelli
2019-03-01 16:05 ` [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID Jiri Pirko
2019-03-02 2:53 ` Florian Fainelli
2019-03-02 7:34 ` Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 3/8] net: devlink: introduce devlink_compat_switch_id_get() helper Jiri Pirko
2019-03-01 16:45 ` Jakub Kicinski
2019-03-01 16:40 ` Jiri Pirko [this message]
2019-03-01 16:05 ` [patch net-next RFC 4/8] mlxsw: Pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-02 2:57 ` Florian Fainelli
2019-03-02 7:36 ` Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 6/8] nfp: pass switch ID through devlink_port_attrs_set() Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 7/8] nfp: register devlink port before netdev Jiri Pirko
2019-03-01 16:05 ` [patch net-next RFC 8/8] nfp: remove ndo_get_port_parent_id implementation Jiri Pirko
2019-03-02 2:58 ` Florian Fainelli
2019-03-02 2:58 ` [patch net-next RFC 0/8] net: expose switch ID via devlink Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301164051.GM2314@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).