From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C48C6C43381 for ; Fri, 1 Mar 2019 16:50:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FA1C20818 for ; Fri, 1 Mar 2019 16:50:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="MQox8jpi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389073AbfCAQuq (ORCPT ); Fri, 1 Mar 2019 11:50:46 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:41214 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728346AbfCAQuq (ORCPT ); Fri, 1 Mar 2019 11:50:46 -0500 Received: by mail-wr1-f65.google.com with SMTP id n2so26588821wrw.8 for ; Fri, 01 Mar 2019 08:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=YC7KzSmyAzv5biOl08rmpq/TNfmsKnNAa2cFEWvnclQ=; b=MQox8jpiim8eaYnh5paJgFbRH57Q/MWlQ1HKVszlNseeGQamtlGKTwjcnvJ6unEvlZ 56gVJCkyqrvXD2rxKyC0gpI01HA+kkSxQJeCmzy08VbnvfCPiuDrcYuL3Ig2d6CGFhFH tgVW9uH4wcjXmgdaoZ2opClQKAi7q0uTBaQ3cyw/sHYkTeqDIIJlXo9AoiBCwRvxaJyQ LfZcH6wTop4yTcDQbQefrVhvThwsX1bMSl3P4YJrP9SPz80/ZkwJdK9EtuLNA/Dp/9QE 9v+bZ2HgUY5YBABQsvqtsX1neU9CT8AaMyAEGomuv9NcyGQU9mlH+xyjBEpbtB6fEj9V ewYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YC7KzSmyAzv5biOl08rmpq/TNfmsKnNAa2cFEWvnclQ=; b=WtUQFYTXSq1bevYdI8UqvNMEbNTrDS9uVdnrp8tieBXxDQiDF7rw9ljEe+whJ+d8UL xAQBZKsobrJo3zx0KnDWQGbs3Jd2sbFjjHupddbqXF1HlNdGzURPeJAQ3+VN3T/au7Gi 72cDZSIAM80s5WNR9cedWrWCfnpbrhW9kgYTXXcjnlOJncHyVLz8SKXcxZ2Pe1G0FZIT WI9eVIb9NXBoVYpcszNsYHxGH6H/wcXWOmhqyPk1I2+2mewNHw/hZ2eQwJlxV9qtGZ/y 9ii9fOtPKfwomfjFbCoBRyuzVuXwktOfVr6ipi1eX19vyfAxJKLnFVpMC5EJGq9GeiZ5 hIfA== X-Gm-Message-State: APjAAAUjDI9A5KIYmmlJQdC+szLVGoCp4gV2u6YVLBLVp6yFUDRnnc/y yqUiVspPoEvkYIN0TlJk4p/5EQ== X-Google-Smtp-Source: APXvYqyBgLtHu5fq0f8wAikSlto4rvUivEFTfZxNcxgldk5Z5DZbI+1L9CsJ7zDtf6Xw3tpO/rubNA== X-Received: by 2002:a5d:4711:: with SMTP id y17mr4321367wrq.141.1551459044638; Fri, 01 Mar 2019 08:50:44 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id q135sm15683190wme.43.2019.03.01.08.50.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 08:50:44 -0800 (PST) Date: Fri, 1 Mar 2019 17:40:51 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, dirk.vandermerwe@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next RFC 3/8] net: devlink: introduce devlink_compat_switch_id_get() helper Message-ID: <20190301164051.GM2314@nanopsycho> References: <20190301160542.6474-1-jiri@resnulli.us> <20190301160542.6474-4-jiri@resnulli.us> <20190301084515.5b378b37@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190301084515.5b378b37@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Mar 01, 2019 at 05:45:15PM CET, jakub.kicinski@netronome.com wrote: >On Fri, 1 Mar 2019 17:05:37 +0100, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Introduce devlink_compat_switch_id_get() helper which fills up switch_id >> according to passed netdev pointer. Call it directly from >> dev_get_port_parent_id() as a fallback when ndo_get_port_parent_id >> is not defined for given netdev. >> >> Signed-off-by: Jiri Pirko > >Here my locking concerns are even stronger :S Do you want to introduce >some extra ordering rules regarding lifetime of devlink ports and their >netdevs? Working on it.