From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex
Date: Fri, 1 Mar 2019 23:31:31 +0100 [thread overview]
Message-ID: <20190301223131.GH25843@lunn.ch> (raw)
In-Reply-To: <ac422522-a37a-853f-3b30-a013312f12bc@gmail.com>
On Fri, Mar 01, 2019 at 07:53:57PM +0100, Heiner Kallweit wrote:
> When testing another issue I faced the problem that
> mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed
> as argument to mv88e6xxx_port_set_duplex(). We should handle this case
> gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed()
> is doing it.
>
> Fixes: 7f1ae07b51e8 ("net: dsa: mv88e6xxx: add port duplex setter")
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-03-01 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 18:53 [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex Heiner Kallweit
2019-03-01 22:31 ` Andrew Lunn [this message]
2019-03-04 5:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301223131.GH25843@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).