* [PATCH net] net: dsa: mv88e6xxx: Fix statistics on mv88e6161
@ 2019-03-01 22:43 Andrew Lunn
2019-03-02 8:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2019-03-01 22:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Vivien Didelot, Chris Healy, Andrew Lunn
Despite what the datesheet says, the silicon implements the older way
of snapshoting the statistics. Change the op.
Reported-by: Chris.Healy@zii.aero
Tested-by: Chris.Healy@zii.aero
Fixes: 0ac64c394900 ("net: dsa: mv88e6xxx: mv88e6161 uses mv88e6320 stats snapshot")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index 9d36d2b5fbc6..65d1a752b679 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3093,7 +3093,7 @@ static const struct mv88e6xxx_ops mv88e6161_ops = {
.port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
.port_link_state = mv88e6352_port_link_state,
.port_get_cmode = mv88e6185_port_get_cmode,
- .stats_snapshot = mv88e6320_g1_stats_snapshot,
+ .stats_snapshot = mv88e6xxx_g1_stats_snapshot,
.stats_set_histogram = mv88e6095_g1_stats_set_histogram,
.stats_get_sset_count = mv88e6095_stats_get_sset_count,
.stats_get_strings = mv88e6095_stats_get_strings,
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: dsa: mv88e6xxx: Fix statistics on mv88e6161
2019-03-01 22:43 [PATCH net] net: dsa: mv88e6xxx: Fix statistics on mv88e6161 Andrew Lunn
@ 2019-03-02 8:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-02 8:45 UTC (permalink / raw)
To: andrew; +Cc: netdev, vivien.didelot, Chris.Healy
From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 1 Mar 2019 23:43:39 +0100
> Despite what the datesheet says, the silicon implements the older way
> of snapshoting the statistics. Change the op.
>
> Reported-by: Chris.Healy@zii.aero
> Tested-by: Chris.Healy@zii.aero
> Fixes: 0ac64c394900 ("net: dsa: mv88e6xxx: mv88e6161 uses mv88e6320 stats snapshot")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied and queued up for -stable, thanks Andrew.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-02 8:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-01 22:43 [PATCH net] net: dsa: mv88e6xxx: Fix statistics on mv88e6161 Andrew Lunn
2019-03-02 8:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).