From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55582C43381 for ; Sat, 2 Mar 2019 07:44:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 098BC2083D for ; Sat, 2 Mar 2019 07:44:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="NjKseQtG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbfCBHod (ORCPT ); Sat, 2 Mar 2019 02:44:33 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:56046 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfCBHod (ORCPT ); Sat, 2 Mar 2019 02:44:33 -0500 Received: by mail-wm1-f66.google.com with SMTP id q187so210768wme.5 for ; Fri, 01 Mar 2019 23:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BiQrI4AMD3dICC8EeJIr+M6h/pJ812Cm2ho4iSmFPko=; b=NjKseQtG69dZG7VnADQ4IIZQO3U72ipzh6W5bVrKM9pecGCtbMKNlkGd9LQHsy8IVF IIe+wpthfuRWv/o270yRZ87NG4xSTpDy4KT9N/AGTWiI9wxV/DN+iClKvuCxI8vd9hJV 1jLoQQ+XwkOdJJgp87oIfw4KN8jWIjmtME2EF98ClmJQxljMbq1pHo13MoBxavjQIVX5 sTdrfnCvGo1/Rzu3dhfKUtk4SSyi9i2vKNu/1ffK9sAHVwKXFvTZdRDlyW0aTdU6/5CM E9UKhqVNBIHM73EKEuAz26cjSb1D+nQm189WPQR84tbpzZu53s6LWeXaEtADVybFDYhe tFzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BiQrI4AMD3dICC8EeJIr+M6h/pJ812Cm2ho4iSmFPko=; b=Z0SlG1t5QD4c/Xpu6y69NE2mXSo76WobktGu3cyUcq6jWCDqV/dMqCdBmRBJ14Fvij /TKUFLTEJZ839NnP8BJI62RBCn7St4IgtdZVPom7QeNu7lDAiTpwfW/uhNMu+wLz75ed 33nvquUelULKBb9wNxNJXcaj7Veg0G13wWBi/Fs0egiZPw4ewIHiFQH7cy+UmASLoOLv ImC/FJc6PrkOZGO1dyh0eEd+D7FKu42E9re7NBQ9GE7pjJxdCXDlFCwHnq0SnPSvM5sf Onalb7ESJEqISeBK5g5Utwkp1rkoYGueZfSGPC6xUmjTOH0iKfGGBpQn94rjnQtAeRAA GdOg== X-Gm-Message-State: AHQUAubPB5fMPiV2ylhnIC2sUKyxfdPZTcWV/Guz/lE3BO527KPOoxVz j8T2NHNmp9sl2Zav/prL0Z4T1Q== X-Google-Smtp-Source: AHgI3IYgJvu/zEBywEQ1CCMQL2m+1XLoqoaIR6pDjAa2L/HNX0RXF1RxrEte4N0whIIMmL4BuUQjHQ== X-Received: by 2002:a1c:4889:: with SMTP id v131mr5321131wma.146.1551512670670; Fri, 01 Mar 2019 23:44:30 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id y140sm1951037wmd.18.2019.03.01.23.44.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 23:44:30 -0800 (PST) Date: Sat, 2 Mar 2019 08:34:38 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID Message-ID: <20190302073438.GN2314@nanopsycho> References: <20190301160542.6474-1-jiri@resnulli.us> <20190301160542.6474-3-jiri@resnulli.us> <6943ae8f-8415-3638-736a-e32a5c157bff@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6943ae8f-8415-3638-736a-e32a5c157bff@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Mar 02, 2019 at 03:53:47AM CET, f.fainelli@gmail.com wrote: > > >On 3/1/2019 8:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Extend devlink_port_attrs_set() to pass switch ID for ports which are >> part of switch and store it in port attrs. For other ports, this is >> NULL. During dump to userspace only valid switch ID is filled up. >> Note that this allows the driver to group devlink ports into one or more >> switches according to the actual topology. >> >> Signed-off-by: Jiri Pirko >> --- > >[snip] > >> @@ -5415,6 +5423,15 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, >> attrs->port_number = port_number; >> attrs->split = split; >> attrs->split_subport_number = split_subport_number; >> + if (switch_id) { >> + attrs->switch_port = true; >> + if (WARN_ON(switch_id_len > MAX_PHYS_ITEM_ID_LEN)) >> + switch_id_len = MAX_PHYS_ITEM_ID_LEN; >> + memcpy(attrs->switch_id.id, switch_id, switch_id_len); >> + attrs->switch_id.id_len = switch_id_len; >> + } else { >> + attrs->switch_port = false; > >Would not switch_id.id_len != 0 be enough of an indicator that this is a >switch port? Might be, yes. On the other hand. attrs->switch_port is just one bit.. >-- >Florian