From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 130CDC43381 for ; Sat, 2 Mar 2019 07:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C74B32083D for ; Sat, 2 Mar 2019 07:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="MC/3Yixl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726550AbfCBHqE (ORCPT ); Sat, 2 Mar 2019 02:46:04 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50867 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfCBHqD (ORCPT ); Sat, 2 Mar 2019 02:46:03 -0500 Received: by mail-wm1-f68.google.com with SMTP id x7so221444wmj.0 for ; Fri, 01 Mar 2019 23:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Cu9bCX3T4o0G/ZMB+gDQtXgPZbAU8B66ctzBK0ObPig=; b=MC/3Yixl6I15POghqWwudpxeaob0R+g1FVDUV7IF5OnivL/vanjhrCI0mV7afZQRPW QNw6cdB3md2gxDbT/bua1pdwV07FnAaW9nuAfCluFZ5GEXqd1osMRob6RZVMd48tG8NJ TLdbA8mKil6qXrJvfE0qppZ9MUUnDYLOvwl6ZtqZp21Qukwxt3TCyUHtUZZEroK07H7Q 31/JkkrzVlvn9XgEhSZfObHlWIPFaCecvUgY+UtQR7bE0t4spbYaEAvXSjOu5DSNFpk5 ZTJL66A/JdiHOhPQQuxbeLAXd/HZK0yhpz8joMbgCIGezhW5V6JbDH4jXMvdgAMTABIP +oKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cu9bCX3T4o0G/ZMB+gDQtXgPZbAU8B66ctzBK0ObPig=; b=TscGT+A4I08GHJuLViW4fBNuzzx/MqWhhHZ3W/0RVKXY6RjrZQXBWUB1ceCHUDIYWe ioMZjvOxgXA7mwbjiLHl6OwWfLF44/n+RsVx52bpl4nG8La7QAuCo7R5cf1F9AMpxTxD eD2gOGR7dv8jsBwWkB03W4h/bRgyDxZTUfIy30/7hGTfsWwTz1kxZKwlYXou8wz2YE1c BZgSDQxVYu8X/GQTmstaplJbRO9vDsx4xtl6xPop/FSMDTVj6Myg8D2VQleAtMB4RurN RoHtYLsw+3Ua+1YOVyRLWIk/DQd+YQDP+3dbcAmgTonPkhNVKR3FDL6st83Bbd6r+b7q n3Vw== X-Gm-Message-State: AHQUAuZe8K4rb39797C2zr8ydeHb0SuIYOuzDUVIsx3Fi+0uo19ED2yV +0E9iVBFEVs7ystdZf5TXJkNdw== X-Google-Smtp-Source: AHgI3IZU/XnZ+slc7yb4amlTYpOCgcgbKTR+F7jX/cjr/BpuJpemSlDM28Roaz0TBYllA6164ymajg== X-Received: by 2002:a7b:c08b:: with SMTP id r11mr4937836wmh.133.1551512761880; Fri, 01 Mar 2019 23:46:01 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id o18sm776303wrg.40.2019.03.01.23.46.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 23:46:01 -0800 (PST) Date: Sat, 2 Mar 2019 08:36:09 +0100 From: Jiri Pirko To: Florian Fainelli Cc: netdev@vger.kernel.org, davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: Re: [patch net-next RFC 5/8] mlxsw: Remove ndo_get_port_parent_id implementation Message-ID: <20190302073609.GO2314@nanopsycho> References: <20190301160542.6474-1-jiri@resnulli.us> <20190301160542.6474-6-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Mar 02, 2019 at 03:57:07AM CET, f.fainelli@gmail.com wrote: > > >On 3/1/2019 8:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Remove implementation of get_port_parent_id ndo and rely on core calling >> into devlink for the information directly. >> >> Signed-off-by: Jiri Pirko > >Don't you need a select/depends on DEVLINK for MLXSW_SWITCHX2 and >MLXSW_SPECTRUM otherwise you are going to get unexpected results from >net/bridge/br_switchdev.c while computing the offload_fwd_mark? You are probably right. That is what we loose after move to devlink-buildin. I think that every driver using devlink should enforce devlink=y >-- >Florian