From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX
Date: Sat, 2 Mar 2019 21:13:07 +0100 [thread overview]
Message-ID: <20190302201307.GA10359@lunn.ch> (raw)
In-Reply-To: <b81d5166-aa61-5851-6e7a-6c78589122e3@gmail.com>
On Sat, Mar 02, 2019 at 04:57:32PM +0100, Heiner Kallweit wrote:
> Propagate the external PHY settings also in 1000BaseX and
> 2500BaseX mode.
Hi Heiner
I don't think this is needed. 1000BaseX and 2500BaseX does not support
inband signalling. So the mac_config() call for these modes should
include the needed speed configuration. I've used 1000BaseX with an
SFP and there was no need to configure anything.
Andrew
next prev parent reply other threads:[~2019-03-02 20:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 15:57 [PATCH net-next] net: dsa: mv88e6xxx: support in-band signalling with external PHY for 1000BaseX/2500BaseX Heiner Kallweit
2019-03-02 20:13 ` Andrew Lunn [this message]
2019-03-02 20:34 ` Heiner Kallweit
2019-03-02 20:36 ` Heiner Kallweit
2019-03-02 20:45 ` Andrew Lunn
2019-03-02 21:03 ` Heiner Kallweit
2019-03-04 18:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190302201307.GA10359@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).