From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B775C43381 for ; Mon, 4 Mar 2019 05:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3ACF92082F for ; Mon, 4 Mar 2019 05:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbfCDFEO (ORCPT ); Mon, 4 Mar 2019 00:04:14 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56922 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbfCDFEO (ORCPT ); Mon, 4 Mar 2019 00:04:14 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D070214D07F19; Sun, 3 Mar 2019 21:04:13 -0800 (PST) Date: Sun, 03 Mar 2019 21:04:13 -0800 (PST) Message-Id: <20190303.210413.17352987714231736.davem@davemloft.net> To: hkallweit1@gmail.com Cc: vivien.didelot@gmail.com, andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH net] net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 03 Mar 2019 21:04:14 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Heiner Kallweit Date: Fri, 1 Mar 2019 19:53:57 +0100 > When testing another issue I faced the problem that > mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed > as argument to mv88e6xxx_port_set_duplex(). We should handle this case > gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed() > is doing it. > > Fixes: 7f1ae07b51e8 ("net: dsa: mv88e6xxx: add port duplex setter") > Signed-off-by: Heiner Kallweit Applied and queued up for -stable, thanks Heiner.