From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DB6C43381 for ; Mon, 4 Mar 2019 18:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52E01206BA for ; Mon, 4 Mar 2019 18:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727197AbfCDSxf (ORCPT ); Mon, 4 Mar 2019 13:53:35 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37616 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727079AbfCDSxf (ORCPT ); Mon, 4 Mar 2019 13:53:35 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D56E014712105; Mon, 4 Mar 2019 10:53:34 -0800 (PST) Date: Mon, 04 Mar 2019 10:53:34 -0800 (PST) Message-Id: <20190304.105334.44578362375613868.davem@davemloft.net> To: wenxu@ucloud.cn Cc: vladbu@mellanox.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net/sched: act_tunnel_key: Fix double free dst_cache From: David Miller In-Reply-To: <1551538221-27674-1-git-send-email-wenxu@ucloud.cn> References: <1551538221-27674-1-git-send-email-wenxu@ucloud.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Mar 2019 10:53:35 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: wenxu@ucloud.cn Date: Sat, 2 Mar 2019 22:50:21 +0800 > From: wenxu > > dst_cache_destroy will be called in dst_release > > dst_release-->dst_destroy_rcu-->dst_destroy-->metadata_dst_free > -->dst_cache_destroy > > It should not call dst_cache_destroy before dst_release > > Fixes: 41411e2fd6b8 ("net/sched: act_tunnel_key: Add dst_cache support") > Signed-off-by: wenxu This does not apply cleanly to net-next, please respin.