From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9D3CC43381 for ; Mon, 4 Mar 2019 18:58:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FD0420663 for ; Mon, 4 Mar 2019 18:58:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726994AbfCDS6a (ORCPT ); Mon, 4 Mar 2019 13:58:30 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37690 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbfCDS63 (ORCPT ); Mon, 4 Mar 2019 13:58:29 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5A6D714712112; Mon, 4 Mar 2019 10:58:29 -0800 (PST) Date: Mon, 04 Mar 2019 10:58:28 -0800 (PST) Message-Id: <20190304.105828.158200054939679540.davem@davemloft.net> To: idosch@mellanox.com Cc: netdev@vger.kernel.org, jiri@mellanox.com, mlxsw@mellanox.com Subject: Re: [PATCH net] team: Free BPF filter when unregistering netdev From: David Miller In-Reply-To: <20190303073516.10798-1-idosch@mellanox.com> References: <20190303073516.10798-1-idosch@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Mar 2019 10:58:29 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Date: Sun, 3 Mar 2019 07:35:51 +0000 > When team is used in loadbalance mode a BPF filter can be used to > provide a hash which will determine the Tx port. > > When the netdev is later unregistered the filter is not freed which > results in memory leaks [1]. > > Fix by freeing the program and the corresponding filter when > unregistering the netdev. ... > Fixes: 01d7f30a9f96 ("team: add loadbalance mode") > Signed-off-by: Ido Schimmel > Reported-by: Amit Cohen Applied and queued up for -stable.