From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D186EC43381 for ; Mon, 4 Mar 2019 18:59:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A941A20663 for ; Mon, 4 Mar 2019 18:59:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbfCDS7b (ORCPT ); Mon, 4 Mar 2019 13:59:31 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:37700 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726180AbfCDS7b (ORCPT ); Mon, 4 Mar 2019 13:59:31 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B0D74147120FF; Mon, 4 Mar 2019 10:59:30 -0800 (PST) Date: Mon, 04 Mar 2019 10:59:30 -0800 (PST) Message-Id: <20190304.105930.1367812295017801292.davem@davemloft.net> To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH net] sctp: call iov_iter_revert() after sending ABORT From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 04 Mar 2019 10:59:30 -0800 (PST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Sun, 3 Mar 2019 16:50:26 +0800 > The user msg is also copied to the abort packet when doing SCTP_ABORT in > sctp_sendmsg_check_sflags(). When SCTP_SENDALL is set, iov_iter_revert() > should have been called for sending abort on the next asoc with copying > this msg. Otherwise, memcpy_from_msg() in sctp_make_abort_user() will > fail and return error. > > Fixes: 4910280503f3 ("sctp: add support for snd flag SCTP_SENDALL process in sendmsg") > Reported-by: Ying Xu > Signed-off-by: Xin Long Applied and queued up for -stable.