From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA369C43381 for ; Mon, 4 Mar 2019 07:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C7D820823 for ; Mon, 4 Mar 2019 07:03:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="INupQZt6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbfCDHDs (ORCPT ); Mon, 4 Mar 2019 02:03:48 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38555 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfCDHDs (ORCPT ); Mon, 4 Mar 2019 02:03:48 -0500 Received: by mail-wr1-f67.google.com with SMTP id g12so4218352wrm.5 for ; Sun, 03 Mar 2019 23:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Nu2Rvh2Q8NsFLI2pZtZhbBFXJoYHKlKuAM2H6p4El1E=; b=INupQZt6oIssO8cKh9WM3uX8rw7wHYwL660xbO1+xEQvP89EyLCHuAFPENFz8g8W8c bI10gbbgOLAZ5Ti3Jcc92waRj6AHEsMhCkPhOxqwm6Tq4N7HT6cTUImH0+dejWh/3fck GKwZv9WMsvIdZD0O13O7HMe3IgrOSnPQ5xkDOXJfub4pedwcg5hWpKvs1Qwt2eT+BQJz AUdk3m1vpjflmEcCJnDv3KqL+DdRpIje4L3VcZbJFFRpdi7bQwv5bZuvO9nvWsy/AJBp LpQtphK/tVmGuCvgvuGM/ao53nfyKQIJS3cKY93+x4KE7oY0ZGHTldxGlAMlY6UG0+2Z ghww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Nu2Rvh2Q8NsFLI2pZtZhbBFXJoYHKlKuAM2H6p4El1E=; b=e4C8uMaxAJDd+/aWGCy52hcEJdwifjgrk6hkNnCZCHve1wINPBTat2P1FNHiwKeAN6 5pbQS594DRMaYEm1b83h9+5hD7Br9L4GSP1zNryBCN4OmYsbugeDBR2owuiMx15+WG9i vkM++kV8XdVScFtIQzo4nQC4fRNDQjM8ZfwzIx75zMJCb5oDCzHhvI81htNE5GOCKGh0 yMvmlJvWlpM8qVsTWlW5xaL0XowChiO9Oc+xp7Eoxqml2yEz6QvraPV+LR9Sl2odyr9G LKZhiWPQquSOJiiOGmz8YGrSemVTba2rLtAfOR2F9vkUUhXVxxi8xfSIPzPYYrwmF6Ac 4T/w== X-Gm-Message-State: APjAAAVvLQ4tyY+n+nrhCEwe78CchGyyDbeO4z9TCBxPv11dnt2HWExm q7xFzbRib3gtOdujgs7nreWPCA== X-Google-Smtp-Source: APXvYqwb41gdi25k99vTzPE3J60AQHY3IVxBiwpvKUuGzcokBRH6TU76ZTyEJnxNGmTfnjRgsvvnnQ== X-Received: by 2002:adf:fdc3:: with SMTP id i3mr10904654wrs.252.1551683026333; Sun, 03 Mar 2019 23:03:46 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id 11sm3945679wmg.27.2019.03.03.23.03.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 03 Mar 2019 23:03:45 -0800 (PST) Date: Mon, 4 Mar 2019 07:53:57 +0100 From: Jiri Pirko To: Ido Schimmel Cc: "netdev@vger.kernel.org" , "davem@davemloft.net" , Jiri Pirko , mlxsw Subject: Re: [PATCH net] team: Free BPF filter when unregistering netdev Message-ID: <20190304065357.GS2314@nanopsycho> References: <20190303073516.10798-1-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190303073516.10798-1-idosch@mellanox.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sun, Mar 03, 2019 at 08:35:51AM CET, idosch@mellanox.com wrote: >When team is used in loadbalance mode a BPF filter can be used to >provide a hash which will determine the Tx port. > >When the netdev is later unregistered the filter is not freed which >results in memory leaks [1]. > >Fix by freeing the program and the corresponding filter when >unregistering the netdev. > >[1] >unreferenced object 0xffff8881dbc47cc8 (size 16): > comm "teamd", pid 3068, jiffies 4294997779 (age 438.247s) > hex dump (first 16 bytes): > a3 00 6b 6b 6b 6b 6b 6b 88 a5 82 e1 81 88 ff ff ..kkkkkk........ > backtrace: > [<000000008a3b47e3>] team_nl_cmd_options_set+0x88f/0x11b0 > [<00000000c4f4f27e>] genl_family_rcv_msg+0x78f/0x1080 > [<00000000610ef838>] genl_rcv_msg+0xca/0x170 > [<00000000a281df93>] netlink_rcv_skb+0x132/0x380 > [<000000004d9448a2>] genl_rcv+0x29/0x40 > [<000000000321b2f4>] netlink_unicast+0x4c0/0x690 > [<000000008c25dffb>] netlink_sendmsg+0x929/0xe10 > [<00000000068298c5>] sock_sendmsg+0xc8/0x110 > [<0000000082a61ff0>] ___sys_sendmsg+0x77a/0x8f0 > [<00000000663ae29d>] __sys_sendmsg+0xf7/0x250 > [<0000000027c5f11a>] do_syscall_64+0x14d/0x610 > [<000000006cfbc8d3>] entry_SYSCALL_64_after_hwframe+0x49/0xbe > [<00000000e23197e2>] 0xffffffffffffffff >unreferenced object 0xffff8881e182a588 (size 2048): > comm "teamd", pid 3068, jiffies 4294997780 (age 438.247s) > hex dump (first 32 bytes): > 20 00 00 00 02 00 00 00 30 00 00 00 28 f0 ff ff .......0...(... > 07 00 00 00 00 00 00 00 28 00 00 00 00 00 00 00 ........(....... > backtrace: > [<000000002daf01fb>] lb_bpf_func_set+0x45c/0x6d0 > [<000000008a3b47e3>] team_nl_cmd_options_set+0x88f/0x11b0 > [<00000000c4f4f27e>] genl_family_rcv_msg+0x78f/0x1080 > [<00000000610ef838>] genl_rcv_msg+0xca/0x170 > [<00000000a281df93>] netlink_rcv_skb+0x132/0x380 > [<000000004d9448a2>] genl_rcv+0x29/0x40 > [<000000000321b2f4>] netlink_unicast+0x4c0/0x690 > [<000000008c25dffb>] netlink_sendmsg+0x929/0xe10 > [<00000000068298c5>] sock_sendmsg+0xc8/0x110 > [<0000000082a61ff0>] ___sys_sendmsg+0x77a/0x8f0 > [<00000000663ae29d>] __sys_sendmsg+0xf7/0x250 > [<0000000027c5f11a>] do_syscall_64+0x14d/0x610 > [<000000006cfbc8d3>] entry_SYSCALL_64_after_hwframe+0x49/0xbe > [<00000000e23197e2>] 0xffffffffffffffff > >Fixes: 01d7f30a9f96 ("team: add loadbalance mode") >Signed-off-by: Ido Schimmel >Reported-by: Amit Cohen Acked-by: Jiri Pirko