From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F110AC43381 for ; Mon, 4 Mar 2019 08:06:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A2CD42082F for ; Mon, 4 Mar 2019 08:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="bSSgY6LY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726032AbfCDIGC (ORCPT ); Mon, 4 Mar 2019 03:06:02 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:34973 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbfCDIGC (ORCPT ); Mon, 4 Mar 2019 03:06:02 -0500 Received: by mail-wm1-f68.google.com with SMTP id y15so3678731wma.0 for ; Mon, 04 Mar 2019 00:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZH+cT6FWdbhpwIVm2/c9eL1i016C4khOY2rzTNYN1Sw=; b=bSSgY6LYUa2l1GmD8iXM9AMtaZj9G+2SrZYW0MAb3QoDrA5FcBMY+Jp5Z6bIpWN+iP 3uobIZpFSpAMLKchEkAAfrbjdtJXog3NT9sRp85exg2sRGYoAApAIR4qOhNFR013hL/z o8iHTABbO5tdMgRZsdwswIbOx/ekla0NoiUchTxVhaAamLSKCB/OeN4P6ZhAPgOdHvNm IQF2/NI4JE1EuU6B2Qo29G7CXA61Lpj/okGkCY4bV0/Onps3uSv082SX4rsdM3UXL3ur tdQNa4E9z9s1sdeA4f3pESA6HJQ+46mJ8U0UMPGZZlrLRvTa+08XI/5o48YdF6j1+ngT KZWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZH+cT6FWdbhpwIVm2/c9eL1i016C4khOY2rzTNYN1Sw=; b=Qz0XzctTdbgf/BRRmTmN18QHBeu6zQEh7tZ3yKWcuEXHa/lBIfbOmouznTDoiDsQgv WVbdZHKBwfp3JD0FgfwpWsuBpsYqGUon+oCbtO2jWSKWRk++m52lpDYwA54DsR2CPoDQ QHN3aMIwKYdom3mhvJ6LBg/WF7y0utUZEPOLHfJrhHVrCKZlES5ZzVhOVMPLQOq0dDYK Q6IL2xpDLPkaevDjwhUzAz1PDY08LLMfgN3+tihiVwuiAZMbzA71JVvD5IdJKSvZLjfh Zve9K956ZgDubS4PctWyNLAGAg4ehmn28YwLIEP97i5sA8k6wPhqWTjcL6ZWLV37mQJE e4rA== X-Gm-Message-State: AHQUAuaIihfLOME8LXOQbvgBpWrcnDMA+h9RimXHhT9FsDCZtnGu/9co fqQ4HCMLgW9/fza0Pgn/OTPRGw== X-Google-Smtp-Source: AHgI3IZl8knNo62ecyD9TSUbOVfCmkMi59D175zXv0QpTN83SzIO9AtycuBwcvhXqaOeTcfITHLOlA== X-Received: by 2002:a7b:cc18:: with SMTP id f24mr11051077wmh.42.1551686759166; Mon, 04 Mar 2019 00:05:59 -0800 (PST) Received: from localhost (ip-89-177-134-16.net.upcbroadband.cz. [89.177.134.16]) by smtp.gmail.com with ESMTPSA id o127sm8576554wmo.20.2019.03.04.00.05.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 00:05:58 -0800 (PST) Date: Mon, 4 Mar 2019 08:56:09 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, oss-drivers@netronome.com Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190304075609.GV2314@nanopsycho> References: <20190301180453.17778-1-jakub.kicinski@netronome.com> <20190301180453.17778-5-jakub.kicinski@netronome.com> <20190302094116.GQ2314@nanopsycho> <20190302114847.733759a1@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190302114847.733759a1@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Sat, Mar 02, 2019 at 08:48:47PM CET, jakub.kicinski@netronome.com wrote: >On Sat, 2 Mar 2019 10:41:16 +0100, Jiri Pirko wrote: >> Fri, Mar 01, 2019 at 07:04:50PM CET, jakub.kicinski@netronome.com wrote: >> >PCI endpoint corresponds to a PCI device, but such device >> >can have one more more logical device ports associated with it. >> >We need a way to distinguish those. Add a PCI subport in the >> >dumps and print the info in phys_port_name appropriately. >> > >> >This is not equivalent to port splitting, there is no split >> >group. It's just a way of representing multiple netdevs on >> >a single PCI function. >> > >> >Note that the quality of being multiport pertains only to >> >the PCI function itself. A PF having multiple netdevs does >> >not mean that its VFs will also have multiple, or that VFs >> >are associated with any particular port of a multiport VF. >> > >> >Example (bus 05 device has subports, bus 82 has only one port per >> >function): >> > >> >$ devlink port >> >pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical >> >pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 >> >pci/0000:05:00.0/4: type eth netdev enp5s0np1 flavour physical >> >pci/0000:05:00.0/11000: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 >> >> So these subport devlink ports are eswitch ports for subports, right? >> >> Please see the following drawing: >> >> +---+ +---+ +---+ >> pfsub| 5 | vf| 6 | | 7 |pfsub >> +-+-+ +-+-+ +-+-+ >> physical link <---------+ | | | >> | | | | >> | | | | >> | | | | >> +-+-+ +-+-+ +-+-+ +-+-+ >> | 1 | | 2 | | 3 | | 4 | >> +--+---+------+---+------+---+------+---+--+ >> | physical pfsub vf pfsub | >> | port port port port | >> | | >> | eswitch | >> | | >> | | >> +------------------------------------------+ >> >> 1) pci/0000:05:00.0/0: type eth netdev enp5s0np0 flavour physical switch_id 00154d130d2f >> 2) pci/0000:05:00.0/10000: type eth netdev enp5s0npf0s0 flavour pci_pf pf 0 subport 0 switch_id 00154d130d2f >> 3) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0vf0 flavour pci_vf pf 0 vf 0 switch_id 00154d130d2f >> 4) pci/0000:05:00.0/10001: type eth netdev enp5s0npf0s1 flavour pci_pf pf 0 subport 1 switch_id 00154d130d2f >> >> This is basically what you have and I think we are in sync with that. >> But what about 5,6,7? Should they have devlink port instances too? >> >> 5) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 0 >> 6) pci/0000:05:10.1/0: type eth netdev enp5s10f0 flavour ???? pf 0 vf 0 >> 7) pci/0000:05:00.0/1: type eth netdev enp5s0f0?? flavour ???? pf 0 subport 1 >> >> These are the "peers". >> I think that there could be flavours "pci_pf" and "pci_vf". Then the >> "representors" (switch ports) could have flavours "pci_pf_port" and >> "pci_vf_port" or something like that. User can see right away >> that is not "PF" of "VF" but rather something "on the other end". >> Note there is no "switch_id" for these devlink ports that tells the user >> these devlink ports are not part of any switch. >> What do you think? > >Hmmm.. Hm. Hm. > >To me its neat if the devlink instance matches an ASIC. I think it's >kind of clear for people to understand what it stands for then. So if >we wanted to do the above we'd have to make the switch_id the first >class identifier for devlink instances, rather than the bus? But then What do you mean by "first class identifier"? Like "a handle"? >VF instances don't have a switch ID so that doesn't work... Wait a sec. VF-ports do have. VFs them selves don't. But that is the same for PF. PF would also not have switch id. > >I need to think about it. > >It's also kind of strange that we have to add the noun *port* to the >flavour of... a port... So I would prefer not to have those showing up Yeah. >as ports. Can we invent a new command (say "partition"?) that'd take >the bus info where the partition is to be spawned? Got it. But the question is how different this object would be from the existing "port" we have today. > >My next goal is to find a way of grouping multiple bus devices under one >"ASIC" (which is a devlink instance to me) so it can be understood >easily how things are laid out when there is more than one PF connected >to one host. These are the "aliases" you mentioned before right? Makes sense.