From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64976C43381 for ; Mon, 4 Mar 2019 17:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F9C320684 for ; Mon, 4 Mar 2019 17:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="rBSIAxYU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbfCDRJJ (ORCPT ); Mon, 4 Mar 2019 12:09:09 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:45369 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbfCDRJJ (ORCPT ); Mon, 4 Mar 2019 12:09:09 -0500 Received: by mail-qk1-f196.google.com with SMTP id v139so3177461qkb.12 for ; Mon, 04 Mar 2019 09:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=IQrJn8SSuwJhmhgEbJlEGmYOZZlgXf5ZXvRnmjJAtlU=; b=rBSIAxYUZw6Ng1mlkAiGqK5/2iC2wRt9YkcAYvJD7QTwlcq63K365Hg/gxthlCV0LP QoqdTmkGUcu8uk5bDRTg4jQx8qrHpK/mGGcrz/36fMmJ3LES55nXJEQSzkHIpOGe5eB1 P5o5ezq75e0gIk5052+nXiiHTl/pFbepbokITPTz0JAJppwrQWw3JIEQ75TJLw7MGNVP y9ouc+SVxBj39Af4dzHPbqD7ZRkO9UyCGoiLe6VJybrinp/KZGB5Fu12IiZeSdZ0rlQR nAmQMVTWyzDS25Be0GAps1hhc0e/X7LAkbh/lm7Y2RyoF/jvRCqRaajNamu4m2Y0cNJU hEPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=IQrJn8SSuwJhmhgEbJlEGmYOZZlgXf5ZXvRnmjJAtlU=; b=iPFnKBX67LSGeoI45fgDAiZTs/5Xtwhn3vVqYbP86ZYNhHac7Odqs0kM/bgw6iRc7n XeDAtZoowxQQFBaNUNGezedWekH5qvR9znVs4iFx82c9aA7yyXRXh5UZGtRhqc8ukeDX dVahzK2FImHPrIVEJ6SK2g7JU7Stuq4DVuIwuyS9c3k33FG0l7yHG4H/wbPHYhgKf6XV VtyOiAm1T9PruQl8Lr5ls+3947mATg8kedTyJMvxRhphfV7EiKkweSZlLZm3rHpo3aLF e0VeyYb5OCVEcjUy/3Swt0CmXrXIWPxVsCxxcFGdPbmRrnhE4VuRrK2OZriCY/roRp0q LpXw== X-Gm-Message-State: APjAAAX2XStLJMCWd9nVD0vQMWyeeMax11ep0xlisW8FmP+ysfqxCje5 xbVXmupatABGK8bLJYTX3RRh7A== X-Google-Smtp-Source: APXvYqxPqQTmRuubbaVbgFN5/AymmKz65QSrtFICO0SJMX3bVaKgUJ1JZxR60oZW7++tk/1lLmRhkw== X-Received: by 2002:a37:3d6:: with SMTP id 205mr14180007qkd.223.1551719348298; Mon, 04 Mar 2019 09:09:08 -0800 (PST) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id z190sm3729928qkb.9.2019.03.04.09.09.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Mar 2019 09:09:08 -0800 (PST) Date: Mon, 4 Mar 2019 09:08:59 -0800 From: Jakub Kicinski To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: David Miller , netdev@vger.kernel.org, Jesper Dangaard Brouer , Daniel Borkmann , Alexei Starovoitov Subject: Re: [PATCH net-next v3 1/3] xdp: Refactor devmap code in preparation for subsequent additions Message-ID: <20190304090839.09a72330@cakuba.netronome.com> In-Reply-To: <87zhqakdqk.fsf@toke.dk> References: <155144955030.28287.14029975169967438162.stgit@alrua-x1> <155144955040.28287.1075106871059918653.stgit@alrua-x1> <20190301170831.6ae29baa@cakuba.netronome.com> <87zhqakdqk.fsf@toke.dk> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 04 Mar 2019 13:47:47 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > In an earlier version I had a namespace enter/exit notifier in devmap.c > as well, to react to new namespaces. And that notifier has a comment > about avoiding calls to synchronize_rcu(). But since this version > doesn't actually need that, maybe I can just keep using direct calls and > synchronize_rcu() and avoid the callback? I'm a bit worried about adding > both synchronize_rcu() and cond_resched() as a possible side effect of > every call to bpf_prog_put(), though; so maybe it's better to move the > cleanup somewhere it's actually safe to call cond_resched(); what would > that be, a workqueue? Workqueue would be my go to.