[PATCH net-next v2 0/7] devlink: expose PF and VF representors as ports

Jakub Kicinski
2019-03-01T18:05:09Z

Hi!

This series is a long overdue follow up to Jiri's work on providing
a common .ndo_phys_port_name implementation based on devlink ports.

First devlink port flavours for PF and VF ports are added, and
registered by the NFP. Port numbers and split info are reserved
for physical and DSA ports. For PCIe ports we add pf/vf identifiers.
Note that devices may have more than one PF, including multi host
scenarios where not all pfs are connected to the same host.

The port_index is slightly tricky to figure out, we use a bit of
math to create unique IDs for ports.

Next subports for PCIe ports are introduced. This is in case device
has more than one netdev on a physical function (e.g. multi port
SmartNIC).

With the above features in place we can remove the ndo_phys_port_name
implementation from the NFP and use the standard devlink one for
port netdevs.

Last but not least a concept of peer netdevs is added. In multi-host
scenarios its currently not possible to figure out which PF is
associated with the local host. Peer device is "the other side
of the wire" for PCIe ports. In case of NFP we only link the PF
netdevs, but it should be possible to also link VF peers after
VF driver probes, if users request it.

This is the conceptual image of devlink instances:

HOST A || HOST B
||
PF A | V | V | V | V || PF B | V | V | V
|*F |*F |*F |*F ... || |*F |*F |*F
*port A0 |*port A1 | 0 | 1 | 2 | 3 ||*port B0 |*port B1 | 0 | 1 | 2
||
PCI Express link || PCI Express link
\ \ \ | | | | | / / /
\ \ \ | | | | | / / /
/\ \______\______\'___|___|__________|_______'____/___/___/__ /\
|| |+PF0s0|+PF0s1 |+VF0|+VF1| ...| |+PF1s0|+PF1s1|+VF0|+VF1| ||
i || |------ ------ ----- ---- ----|--- ------ ------ ---- ----| || i
d n H || | <<========== | || d n H
e s O || | ==========>> | || e s O
v t S || | SR-IOV e-switch | || v t S
l a T || | <<========== | || l a T
i n || | ==========>> | || i n
n c A || | ________ _________ ________ | || n c B
k e || | |+Phys 0 |+Phys 1 |+Phys 2 | | || k e
|| \---------------------------------------------------------/ ||
\/ | | | \/
| | |
|| ||
MAC 0 || MAC 1 || MAC 2
|| ||

'+' marks the devlink ports and port (-representor-) netdevs
'*' marks host netdevs (actual VF/PF netdev)

v2 (Jiri):
- update devlink user space output in a commit message;
- split the pci attribute setting helper into pf and vf versions;
- add peer IBDEV_NAME;
- add nest for peer attributes.

Jakub Kicinski (7):
nfp: split devlink port init from registration
devlink: add PF and VF port flavours
nfp: register devlink ports of all reprs
devlink: allow subports on devlink PCI ports
nfp: switch to devlink_port_get_phys_port_name()
devlink: introduce port's peer netdevs
nfp: expose PF peer netdevs

drivers/net/ethernet/netronome/nfp/abm/main.c | 1 +
.../net/ethernet/netronome/nfp/flower/main.c | 1 +
.../net/ethernet/netronome/nfp/nfp_devlink.c | 54 +++++-
.../net/ethernet/netronome/nfp/nfp_net_main.c | 17 +-
.../net/ethernet/netronome/nfp/nfp_net_repr.c | 16 +-
drivers/net/ethernet/netronome/nfp/nfp_port.c | 33 +---
drivers/net/ethernet/netronome/nfp/nfp_port.h | 4 +
include/net/devlink.h | 48 ++++-
include/uapi/linux/devlink.h | 12 ++
net/core/devlink.c | 178 ++++++++++++++++--
10 files changed, 310 insertions(+), 54 deletions(-)

--
2.19.2