Re: [oss-drivers] Re: [PATCH net-next v2 0/7] devlink: expose PF and VF representors as ports

Jakub Kicinski
2019-03-02T19:49:45Z

On Sat, 2 Mar 2019 11:13:37 +0100, Jiri Pirko wrote:
> >This is the conceptual image of devlink instances:
> >
> > HOST A || HOST B
> > ||
> > PF A | V | V | V | V || PF B | V | V | V
> > |*F |*F |*F |*F ... || |*F |*F |*F
> >*port A0 |*port A1 | 0 | 1 | 2 | 3 ||*port B0 |*port B1 | 0 | 1 | 2
> > ||
> > PCI Express link || PCI Express link
> > \ \ \ | | | | | / / /
> > \ \ \ | | | | | / / /
> > /\ \______\______\'___|___|__________|_______'____/___/___/__ /\
> > || |+PF0s0|+PF0s1 |+VF0|+VF1| ...| |+PF1s0|+PF1s1|+VF0|+VF1| ||
> > i || |------ ------ ----- ---- ----|--- ------ ------ ---- ----| || i
> >d n H || | <<========== | || d n H
> >e s O || | ==========>> | || e s O
> >v t S || | SR-IOV e-switch | || v t S
> >l a T || | <<========== | || l a T
> >i n || | ==========>> | || i n
> >n c A || | ________ _________ ________ | || n c B
> >k e || | |+Phys 0 |+Phys 1 |+Phys 2 | | || k e
> > || \---------------------------------------------------------/ ||
> > \/ | | | \/
> > | | |
> > || ||
> > MAC 0 || MAC 1 || MAC 2
> > || ||
> >
> > '+' marks the devlink ports and port (-representor-) netdevs
> > '*' marks host netdevs (actual VF/PF netdev)
>
> As I wrote in the reply to patch 4, I think we need to figure out if we
> want to model all entities that belong under specific devlink
> instance/pci address - which I prefer, or we want to have only eswitch
> ports there.
>
> One way or another, I think that it is not good idea to merge this
> patchset this late, I would prefer to wait for next net-next opening...
> In the meantime we can sync and make this whole thing crystal clear, for
> everyone.

Makes sense, let's keep talking.