Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports

Jakub Kicinski
2019-03-18T19:36:41Z

On Mon, 18 Mar 2019 16:22:33 +0000, Parav Pandit wrote:
>>>>>>2. flavour should not be vf/pf, flavour should be hostport, switchport.
>>> >Because switch is flat and agnostic of pf/vf/mdev.
>>>>>
>>>>> Not sure. It's good to have this kind of visibility.
>>>>>
>>>> port can have label/attribute indicating that this belong to VF-1 or
>>>> mdev as long as you are agreeing to have mdev attribute on host port.
>>>> (and not ask for abstracting it, because mdev is well defined kernel object).
>>>
>>> Why mdev cannot be another flavour?
>>>
>>
>> hostport is of type pf/vf/mdev connected to some switchport.
>>
>> So proposal is to have,
>> port flavour = hostport/switchport
>> port type/label = pf/vf/mdev
>>
> Instead of having two attributes per port, how about having,
> port flavour= physical/cpu/dsa/pf/vf/mdev/switchport.
>
> physical and pf has some overlapping definitions.

What "overlapping definitions" do physical and PF have?
Sounds like you're referring to limitations of Mellanox HW.