From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver
Date: Mon, 4 Mar 2019 14:53:05 +0100 [thread overview]
Message-ID: <20190304135305.GD26378@lunn.ch> (raw)
In-Reply-To: <CA+h21hr7+HX64XGHY-LCZXkLLk3dGxx8JnALHTc=+Phvx=LU0Q@mail.gmail.com>
> I do see that neither vitesse-vsc73xx nor rtl8366 do implement the bridge
> membership callbacks, and as I don't happen to know nearly enough about DSA, I
> wonder at what moment in time does forwarding get activated between ports.
If those callbacks are not implement, it means the software bridge
does the forwarding. The hardware is not used.
The DSA model allows you to start simple and just implement something
like a port multiplexor. All frames get passed to the host, and the
host then decides what to do with them.
You can then add more callbacks and make more use of the hardware,
e.g. get the hardware to bridge between ports.
If the hardware is not capable of supporting vlan filtering, but you
can support simpler modes, you should implement what you can, and
return an error when asked to do something which it cannot support.
Andrew
next prev parent reply other threads:[~2019-03-04 13:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 12:35 [PATCH 0/3] DSA driver for Vitesse VSC73xx Linus Walleij
2018-06-14 12:35 ` [PATCH 1/3] net: dsa: Add DT bindings for Vitesse VSC73xx switches Linus Walleij
2018-06-14 16:09 ` Florian Fainelli
2018-06-14 16:09 ` Florian Fainelli
2018-06-17 7:40 ` Jiri Pirko
2018-06-14 12:35 ` [PATCH 2/3] net: phy: vitesse: Add support for VSC73xx Linus Walleij
2018-06-14 16:29 ` Florian Fainelli
2018-06-15 19:24 ` Woojung.Huh
2018-06-28 18:23 ` Linus Walleij
2018-06-14 12:35 ` [PATCH 3/3] net: dsa: Add Vitesse VSC73xx DSA router driver Linus Walleij
2018-06-14 16:51 ` Florian Fainelli
2018-06-30 11:05 ` Linus Walleij
2018-06-30 11:05 ` Linus Walleij
2019-03-03 12:08 ` Vladimir Oltean
2019-03-04 9:51 ` Linus Walleij
2019-03-04 12:14 ` Vladimir Oltean
2019-03-04 12:26 ` Linus Walleij
2019-03-04 13:53 ` Andrew Lunn [this message]
2019-03-04 14:10 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190304135305.GD26378@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).