* [net 1/1] tipc: fix RDM/DGRAM connect() regression
@ 2019-03-04 22:26 Jon Maloy
2019-03-05 20:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jon Maloy @ 2019-03-04 22:26 UTC (permalink / raw)
To: davem, netdev
Cc: gordan.mihaljevic, tung.q.nguyen, hoang.h.le, jon.maloy,
canh.d.luu, ying.xue, tipc-discussion
From: Erik Hugne <erik.hugne@gmail.com>
Fix regression bug introduced in
commit 365ad353c256 ("tipc: reduce risk of user starvation during link
congestion")
Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached
sockaddr.
Signed-off-by: Erik Hugne <erik.hugne@gmail.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
---
net/tipc/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 70343ac..139694f 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -1333,7 +1333,7 @@ static int __tipc_sendmsg(struct socket *sock, struct msghdr *m, size_t dlen)
if (unlikely(!dest)) {
dest = &tsk->peer;
- if (!syn || dest->family != AF_TIPC)
+ if (!syn && dest->family != AF_TIPC)
return -EDESTADDRREQ;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net 1/1] tipc: fix RDM/DGRAM connect() regression
2019-03-04 22:26 [net 1/1] tipc: fix RDM/DGRAM connect() regression Jon Maloy
@ 2019-03-05 20:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-05 20:50 UTC (permalink / raw)
To: jon.maloy
Cc: netdev, gordan.mihaljevic, tung.q.nguyen, hoang.h.le, canh.d.luu,
ying.xue, tipc-discussion
From: Jon Maloy <jon.maloy@ericsson.com>
Date: Mon, 4 Mar 2019 23:26:10 +0100
> From: Erik Hugne <erik.hugne@gmail.com>
>
> Fix regression bug introduced in
> commit 365ad353c256 ("tipc: reduce risk of user starvation during link
> congestion")
>
> Only signal -EDESTADDRREQ for RDM/DGRAM if we don't have a cached
> sockaddr.
>
> Signed-off-by: Erik Hugne <erik.hugne@gmail.com>
> Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Please provide a proper Fixes: tag next time, I fixed it up for you
this time around.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-05 20:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-04 22:26 [net 1/1] tipc: fix RDM/DGRAM connect() regression Jon Maloy
2019-03-05 20:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).