From: Stephen Hemminger <stephen@networkplumber.org>
To: si-wei liu <si-wei.liu@oracle.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Jakub Kicinski <kubakici@wp.pl>, Jiri Pirko <jiri@resnulli.us>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
virtualization@lists.linux-foundation.org, liran.alon@oracle.com,
boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com
Subject: Re: [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces
Date: Tue, 5 Mar 2019 11:24:27 -0800 [thread overview]
Message-ID: <20190305112427.1a23822e@shemminger-XPS-13-9360> (raw)
In-Reply-To: <e3b34115-39ca-ac5f-7d53-8bf9e69c910d@oracle.com>
On Tue, 5 Mar 2019 11:19:32 -0800
si-wei liu <si-wei.liu@oracle.com> wrote:
> > I have a vague idea: would it work to *not* set
> > IFF_UP on slave devices at all?
> Hmm, I ever thought about this option, and it appears this solution is
> more invasive than required to convert existing scripts, despite the
> controversy of introducing internal netdev state to differentiate user
> visible state. Either we disallow slave to be brought up by user, or to
> not set IFF_UP flag but instead use the internal one, could end up with
> substantial behavioral change that breaks scripts. Consider any admin
> script that does `ip link set dev ... up' successfully just assumes the
> link is up and subsequent operation can be done as usual. While it *may*
> work for dracut (yet to be verified), I'm a bit concerned that there are
> more scripts to be converted than those that don't follow volatile
> failover slave names. It's technically doable, but may not worth the
> effort (in terms of porting existing scripts/apps).
>
> Thanks
> -Siwei
Won't work for most devices. Many devices turn off PHY and link layer
if not IFF_UP
next prev parent reply other threads:[~2019-03-05 19:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 0:50 [RFC PATCH net-next] failover: allow name change on IFF_UP slave interfaces Si-Wei Liu
2019-03-05 2:33 ` Michael S. Tsirkin
2019-03-05 19:19 ` si-wei liu
2019-03-05 19:24 ` Stephen Hemminger [this message]
2019-03-05 19:35 ` si-wei liu
2019-03-06 0:06 ` Michael S. Tsirkin
2019-03-06 0:20 ` si-wei liu
2019-03-06 0:36 ` Michael S. Tsirkin
2019-03-06 0:51 ` si-wei liu
2019-03-06 6:43 ` Michael S. Tsirkin
2019-03-06 7:15 ` si-wei liu
2019-03-06 7:23 ` Michael S. Tsirkin
2019-03-06 8:20 ` si-wei liu
2019-03-05 20:28 ` Michael S. Tsirkin
2019-03-05 22:49 ` si-wei liu
2019-03-06 12:04 ` Jiri Pirko
[not found] ` <7d1e79f6-01ff-413d-dac0-ee34258aafec@oracle.com>
[not found] ` <cb71d2c4-c2b9-28df-1882-154ee3b9b9b6@intel.com>
[not found] ` <7bc9dc90-6597-4223-c192-55a314ff079f@oracle.com>
2019-03-06 23:36 ` Liran Alon
-- strict thread matches above, loose matches on Subject: below --
2019-03-05 0:36 Si-Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305112427.1a23822e@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=kubakici@wp.pl \
--cc=liran.alon@oracle.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=vijay.balakrishna@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox